fix(sidebar): compact working-agent avatar indicator#1356
Draft
tellaho wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Category: fix
User Impact: The sidebar "working" indicator is now a compact pulsing avatar group instead of a wide text badge, so channel names keep their horizontal space — and a declared owner sees their agent light up even when it runs on another machine.
Problem: The working indicator shipped in #1274 rendered as a
Working · 1m 20stext badge that ate into the channel name's horizontal space. It also decided which agents to show purely on local key custody (managedAgents), so a declared owner whose agent runs on another machine — owning it but holding no local key — would not see their own agent working.Solution: Replace the text badge with a pulsing avatar group (with a who's-working popover), tighten the overflow rule, drop a stray accent border/ring, and widen the visibility gate from key custody to declared ownership — the same NIP-OA
ownerPubkey == viewersignal #1229 standardized across the other owner surfaces. Encryption stays the real security boundary, so the wider read gate leaks nothing.File changes
desktop/src/features/sidebar/ui/SidebarSection.tsx
Replaced the
Working · 1m 20stext badge with a pulsing agent avatar group plus a who's-working popover. Overflow rule: show all avatars when ≤3, collapse to 2 avatars + a "+N" badge past 3. Removed the accentborder/ring-1glow from both the avatars and the +N badge.desktop/src/features/sidebar/lib/useActiveWorkingChannelsById.ts
Widened the working-agent seed from locally managed agents to also include relay agents whose profile
ownerPubkeymatches the current viewer (mirrors the #1229 declared-ownership gate). Dedupes by pubkey, preserving managed-agent status when an agent appears in both sets. Falls back to managed-only when there is no viewer identity.desktop/src/features/agents/activeAgentTurnsStore.ts
Active channel turn summaries now carry
agentPubkeysso the sidebar can resolve avatars for each working agent.desktop/src/features/agents/activeAgentTurnsStore.test.mjs
Updated the store test for the new pubkey aggregation.
Reproduction Steps
Screenshots/Demos
Screenshots of the avatar group, overflow, and popover are being captured against this branch and will be added in review.