[codex] Revalidate workflow owners before webhooks#1373
Draft
jmecom wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
CallWebhooknow reloads the workflow run and workflow row immediately before sending an outbound request, checks the workflow owner's current channel membership against Postgres, and denies the action if the owner has been removed. When that check fails, the workflow is disabled so later channel events do not keep scheduling the same outbound attempt.This closes the workflow exfiltration path where a former private-channel member could leave behind a
message_postedworkflow and continue receiving future message contents through a public webhook.Safety
The check is scoped through the run's community and workflow row, so it does not trust trigger input or the relay's membership cache. Channel-less workflows keep their existing behavior. Membership lookup failures fail closed: the webhook is not sent.
The regression coverage exercises both the allowed path for a current member and the denied path after removal, including the automatic workflow disable.
Testing
cargo fmt --checkcargo test -p buzz-workflow --libcargo clippy -p buzz-relay --lib -- -D warningsenv -u BUZZ_GIT_REPO_PATH cargo test -p buzz-relay --lib -- --test-threads=1Not run:
cargo test -p buzz-workflow --lib webhook_owner_membership_revalidation -- --ignoredbecause local port 5432 is occupied by another project's Postgres and rejects the Buzz test credentials.