Remove check surface-routing; bind checks to prose via source#202
Draft
nahiyankhan wants to merge 1 commit into
Draft
Remove check surface-routing; bind checks to prose via source#202nahiyankhan wants to merge 1 commit into
nahiyankhan wants to merge 1 commit into
Conversation
Checks always fire in the agent-check flow, so the routing gate had no live consumer. Remove the check surface: field, selectChecksForSurfaces, RoutedCheck, and CheckRelevance. review/checks now offer every check and the agent judges relevance; --surface only grounds the named surfaces. Add an optional check source: pointer (node > Heading) — the check's only binding to the graph — which review surfaces so a finding can cite the fingerprint prose it enforces. Soft: an unresolved source is a warning. Records the full triage (Gaps 1-3, OKF/Vercel lens) in docs/ideas/composition-graph-gaps.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes check surface-routing and replaces the check↔graph link with a soft
source:pointer.In the agent-check flow, every check always fires — the agent judges relevance. So the routing gate that
surface:fed had no live consumer. This removes:surface:frontmatter fieldselectChecksForSurfaces,RoutedCheck,CheckRelevance(public exports)route.tsandcheck-route.test.tsreviewandchecksnow offer every check;--surfacesurvives but only grounds the named surfaces (feedsresolveGraphSlice), never filters.Adds an optional
source:pointer on the check —node > Heading(e.g.checkout/payment > Confirmation) — the check's only binding to the graph.reviewsurfaces it (— enforces ...) so a finding can cite the prose it enforces. Soft by design: an unresolvedsource:is a warning, never an error (OKF-style tolerance), mirroring Vercel'sSource: copy.md > Actionable.Why
This branch is the tail of a triage (recorded in
docs/ideas/composition-graph-gaps.md) that evaluated three proposed schema additions against a single lens — does this earn schema an LLM doesn't need? Two were rejected (typed edges,anchors[]); the third (surface:path-routing) was superseded by deleting routing entirely once it became clear checks always fire.Net: −152 lines, one subsystem removed, one small soft pointer added.
Breaking
major— removes public exports (selectChecksForSurfaces,RoutedCheck,CheckRelevance) and the checksurface:field. Changeset included.Verification
build ✓ · 115 tests ✓ · biome ✓ · typecheck ✓ · CLI manifest in sync ✓ · terminology ✓