Skip to content

fix: disable comfy-table terminal features - #5462

Merged
jedel1043 merged 1 commit into
boa-dev:mainfrom
tomasol:pr-comfy-table-wasm
Jul 26, 2026
Merged

fix: disable comfy-table terminal features#5462
jedel1043 merged 1 commit into
boa-dev:mainfrom
tomasol:pr-comfy-table-wasm

Conversation

@tomasol

@tomasol tomasol commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Disables comfy-table’s default tty feature in boa_wintertc. This prevents it from pulling in crossterm, which does not compile for WASM targets.

@tomasol
tomasol requested a review from a team as a code owner July 26, 2026 16:41
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Jul 26, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Jul 26, 2026
@github-actions github-actions Bot added the C-Dependencies Pull requests that update a dependency file label Jul 26, 2026
@github-actions

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,073 51,073 0
Ignored 1,482 1,482 0
Failed 570 570 0
Panics 0 0 0
Conformance 96.14% 96.14% 0.00%

Tested main commit: f54077467b4b01eb0fe221cfff470a8546ebe36c
Tested PR commit: 4c09b610ab8d17e0387f5ce99bf3a73ba0ca53f8
Compare commits: f540774...4c09b61

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.88%. Comparing base (6ddc2b4) to head (4c09b61).
⚠️ Report is 1011 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5462       +/-   ##
===========================================
+ Coverage   47.24%   62.88%   +15.63%     
===========================================
  Files         476      530       +54     
  Lines       46892    59102    +12210     
===========================================
+ Hits        22154    37165    +15011     
+ Misses      24738    21937     -2801     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jedel1043
jedel1043 added this pull request to the merge queue Jul 26, 2026
Merged via the queue into boa-dev:main with commit 4fc75c6 Jul 26, 2026
22 checks passed
@github-actions github-actions Bot removed the Waiting On Review Waiting on reviews from the maintainers label Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants