fix: repair broken Makefile targets and stale server docs - #3777
Open
Vondry wants to merge 4 commits into
Open
Conversation
`phpstan.neon` is gitignored and never committed; only `phpstan.dist.neon` exists in the repo. Passing `-c phpstan.neon` made the target abort with "Project config file ... does not exist", which also broke `cscheck`, `csfix` and `full-test` since they all call `stancheck`. Removing the flag lets PHPStan auto-discover `phpstan.dist.neon`, which already defines `level: 8`, `paths: [src]` and the baseline include. This matches what CI runs (`vendor/bin/phpstan analyse`).
`bin/console server:start` and `server:stop` were provided by symfony/web-server-bundle, which was removed in Symfony 5. The project runs Symfony 6.4 and the bundle is absent from composer.lock and config/bundles.php, so `bin/console list server` only offers server:dump and server:log. Both targets have been failing, which also made `start` unusable since it chains into `server`. Switch to the Symfony CLI, which is what SETUP.md recommends first and what every CI workflow already uses. The port stays 8088 and `|| true` is kept so `make start` remains tolerant of an already-running server.
ecs.php scopes itself to src (plus ecs.php), and CI runs `vendor/bin/ecs check src`. The extra `ecs check tests/php` line meant `make cscheck` reported 13 violations and exited 2 on code that CI accepts, so the target failed before it ever reached stancheck. Drop the extra invocation so the make targets match the ECS config and CI. Note docker-cscheck/docker-csfix already only checked src, so this also brings the two paths back in line.
`bin/console server:start` and `server:run` came from symfony/web-server-bundle, removed in Symfony 5. The bundle is not in composer.lock or config/bundles.php, so neither command exists on this 6.4 codebase and the pcntl caveat is moot (the docker php image installs pcntl regardless). Leaves the Symfony CLI as the single instruction, matching the server/server-stop make targets. Verified `symfony server:start` serves on 127.0.0.1:8000, which is the URL the following paragraph points at.
Vondry
force-pushed
the
fix/makefile-stale-targets
branch
from
August 4, 2026 08:38
ea15567 to
e8b9482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four broken
maketargets without changing project behavior. The changes align local development commands with the current Symfony 6.4 toolchain and existing CI configuration.Changes
stancheckphpstan.neon(gitignored and never committed) to the committedphpstan.dist.neon.cscheck,csfix, andfull-test.server/server-stopbin/console server:*commands from the deprecatedsymfony/web-server-bundlewith the Symfony CLI.cscheck/csfixecs check tests/php, which lies outside the configuredecs.phpscope (and CI's scope).SETUP.mdbin/console server:startandbin/console server:run.