fix(translations): restore dropped placeholders in bg/de/es/hu - #3784
Open
Vondry wants to merge 1 commit into
Open
fix(translations): restore dropped placeholders in bg/de/es/hu#3784Vondry wants to merge 1 commit into
Vondry wants to merge 1 commit into
Conversation
Eight translations omitted a parameter that the caller passes, so the
value never reached the user. Each string is reworded to reinstate it:
messages.bg general.greeting + %name%
messages.bg listing_details_box.listing_template + %listingRecords%
messages.de contenttypes.generic.overview + %contenttypes%
messages.de contenttypes.generic.recent + %contenttypes%
messages.de reset_password.check_email_sent_text_2 + %tryagain%
messages.es collection.add_item + %name%
messages.hu collection.add_item + %name%
messages.hu title.filtered_by %szűrő% -> %filter%
Several were hardcoded workarounds rather than accidents -- the German
ContentType headings read "Seitenübersicht"/"Neueste Seiten", which is
correct only for Pages, and the Bulgarian greeting said "админ" for
every user.
All eight parameters were verified against their callers, e.g.
templates/_base/layout.html.twig:39 '%name%'
public/theme/skeleton/partials/_aside.twig:53,60 '%contenttypes%'
templates/content/listing.html.twig:172 '%listingRecords%'
templates/reset_password/check_email.html.twig:36 '%tryagain%'
The obsolete singular security.de unit ("...in %minutes% minute.") is
deliberately left alone: "in einer Minute" is the correct German for
that message, and reinstating the parameter would render "in 1 Minute".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #3753
Summary
Fixes translations that dropped placeholders required by the calling code, preventing runtime values from being displayed.
Changes
messages.bggeneral.greeting,listing_details_box.listing_templatemessages.decontenttypes.generic.overview,contenttypes.generic.recent,reset_password.check_email_sent_text_2messages.escollection.add_itemmessages.hucollection.add_item,title.filtered_byWhy
Symfony substitutes placeholders by exact name. When a translation omits a placeholder, the corresponding runtime value is lost.
Several of these were effectively hardcoded translations rather than direct equivalents of the source text. For example:
%name%.