fix(translations): replace unresolved %url% in built-with-bolt string - #3785
Open
Vondry wants to merge 1 commit into
Open
fix(translations): replace unresolved %url% in built-with-bolt string#3785Vondry wants to merge 1 commit into
Vondry wants to merge 1 commit into
Conversation
The footer renders this string with no parameters:
public/theme/skeleton/partials/_footer.twig:17
{{ __('general.phrase.built-with-bolt') }}
so the %url% placeholder was never substituted and four locales emitted
a literal href='%url%', producing a broken link. English and eight other
locales hardcode the URL; el/hu/it/tr are brought in line with them.
href='%url%' -> href='https://boltcms.io'
13 <target> elements across 7 files: the live key in el/hu/it/tr, plus
the hash-keyed (9fb3e6e) and unnamed duplicates in cs/el/fr/hu/it/tr/
zh_CN that carry the same string. uk already used the hardcoded form.
Two <source> elements in hu/it carrying the same corrupted English text
are aligned as well, so those units stay internally consistent -- their
canonical English, as held in messages.en.xlf, hardcodes the URL.
The %url% placeholder in http_error.suggestion, http_error_404.suggestion
and http_error_500.suggestion is deliberately untouched: it is present in
messages.en.xlf and used identically by all ten locales that have those
keys, so it is a separate concern from this string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #3753
Why
The footer calls the string with no parameters:
So
%url%was never filled in and rendered literally ashref='%url%'— a relative link that 404'd on every page.The URL is already hardcoded elsewhere
English and 8 of the 12 locales already write the URL directly: en, cs, de, fr, nl, ru, uk, zh_CN.
Only
el,hu,it,trused %url%. This brings them in line:Wording untouched — only the href. Also applied to the unreachable duplicate copies of the same sentence so it can't come back.
%url%inhttp_error*.suggestionis left alone — English uses it there too.