Skip to content

Sync common files from infra repository #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bootc-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sync common files from infra repository #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bootc-dev-infra-commit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
90f71f83e26a74ba93f130c779f70687a2262ae1
574cc5b9bf84f88a9cef3073adda95e4acfc7318
7 changes: 7 additions & 0 deletions REVIEW_RUST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ Several of our projects use the `cargo xtask` pattern to put arbitrary "glue"
code in Rust using the `xshell` crate to keep it easy to run external commands.
This is preferred over long shell scripts.

## Code Formatting

After making changes to any .rs files, `cargo fmt` should be run.
There are CI jobs that lint and expect `cargo fmt` to be a no-op.
Failing to properly format rust code will result in wasted CI
resources.

## General

Prefer rustix over `libc`. All `unsafe` code must be very carefully
Expand Down