-
Notifications
You must be signed in to change notification settings - Fork 2
backup: add live scan primitives #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bootjp
wants to merge
7
commits into
main
Choose a base branch
from
design/live-backup-scanner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bd4a75c
backup: add live scan primitives
bootjp a9f2581
backup: fix scanner cursor exhaustion
bootjp 4b85955
backup: fix key scan pagination edge cases
bootjp 582b2eb
backup: harden scan pagination edge cases
bootjp aa99e90
backup: preserve scan progress across filtered pages
bootjp 9adece8
backup: fix scan pagination edge cases
bootjp 6cc845d
Merge remote-tracking branch 'origin/main' into design/live-backup-sc…
bootjp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package kv | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "context" | ||
|
|
||
| "github.com/bootjp/elastickv/distribution" | ||
| "github.com/bootjp/elastickv/store" | ||
| ) | ||
|
|
||
| const defaultBackupScanPageSize = 1024 | ||
|
|
||
| // BackupScanner pages through ShardStore.ScanAt without holding store locks | ||
| // across pages. | ||
| type BackupScanner interface { | ||
| Next(ctx context.Context) (*store.KVPair, bool, error) | ||
| Close() error | ||
| } | ||
|
|
||
| type backupScanner struct { | ||
| store *ShardStore | ||
| routes []distribution.Route | ||
| clampToRoutes bool | ||
| end []byte | ||
| ts uint64 | ||
| pageSize int | ||
| cursor []byte | ||
| page []*store.KVPair | ||
| index int | ||
| closed bool | ||
| exhausted bool | ||
| } | ||
|
|
||
| func NewBackupScanner(st *ShardStore, start []byte, end []byte, ts uint64, pageSize int) BackupScanner { | ||
| if pageSize <= 0 { | ||
| pageSize = defaultBackupScanPageSize | ||
| } | ||
| var routes []distribution.Route | ||
| var clampToRoutes bool | ||
| if st != nil { | ||
| routes, clampToRoutes = st.routesForScan(start, end) | ||
| routes = append([]distribution.Route(nil), routes...) | ||
| } | ||
| return &backupScanner{ | ||
| store: st, | ||
| routes: routes, | ||
| clampToRoutes: clampToRoutes, | ||
| cursor: bytes.Clone(start), | ||
| end: bytes.Clone(end), | ||
| ts: ts, | ||
| pageSize: pageSize, | ||
| } | ||
| } | ||
|
|
||
| func (s *ShardStore) NewBackupScanner(start []byte, end []byte, ts uint64, pageSize int) BackupScanner { | ||
| return NewBackupScanner(s, start, end, ts, pageSize) | ||
| } | ||
|
|
||
| func (s *backupScanner) Next(ctx context.Context) (*store.KVPair, bool, error) { | ||
| if s.closed || s.store == nil { | ||
| return nil, false, nil | ||
| } | ||
| for s.index >= len(s.page) { | ||
| if err := s.loadNextPage(ctx); err != nil { | ||
| return nil, false, err | ||
| } | ||
| if len(s.page) == 0 { | ||
| return nil, false, nil | ||
| } | ||
| } | ||
| kvp := s.page[s.index] | ||
| s.index++ | ||
| if kvp == nil { | ||
| return nil, true, nil | ||
| } | ||
| return kvp, true, nil | ||
| } | ||
|
|
||
| func (s *backupScanner) Close() error { | ||
| s.closed = true | ||
| s.exhausted = true | ||
| s.page = nil | ||
| return nil | ||
| } | ||
|
|
||
| func (s *backupScanner) loadNextPage(ctx context.Context) error { | ||
| if s.exhausted { | ||
| s.page = nil | ||
| s.index = 0 | ||
| return nil | ||
| } | ||
| page, err := s.store.scanRoutesAtSorted(ctx, s.routes, s.cursor, s.end, s.pageSize, s.ts, s.clampToRoutes) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| s.page = page | ||
| s.index = 0 | ||
| if len(page) == 0 { | ||
| s.exhausted = true | ||
| return nil | ||
|
bootjp marked this conversation as resolved.
|
||
| } | ||
| last := page[len(page)-1] | ||
| if last == nil { | ||
| s.exhausted = true | ||
| return nil | ||
| } | ||
| s.cursor = nextScanCursor(last.Key) | ||
|
bootjp marked this conversation as resolved.
bootjp marked this conversation as resolved.
|
||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.