Skip to content

Mark TTL inline design partial#1080

Open
bootjp wants to merge 1 commit into
mainfrom
design/ttl-inline-partial
Open

Mark TTL inline design partial#1080
bootjp wants to merge 1 commit into
mainfrom
design/ttl-inline-partial

Conversation

@bootjp

@bootjp bootjp commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Author: bootjp

Summary:

  • Move the TTL inline value design from proposed to partial.
  • Record that Redis strings already use inline TTL, while collection/HLL/stream anchors remain on the legacy TTL index.
  • Document implemented and remaining phases against the current adapter code.

Validation:

  • rg -n "2026_04_17_proposed_ttl_inline_value|Status in this PR" .
  • git diff --check
  • GOCACHE=$(pwd)/.cache GOTMPDIR=$(pwd)/.cache/tmp go test ./adapter -run 'TestRedis_MultiExec_SetEXStoresTTL|TestRedis_MisskeySETEX|TestRedis_MultiExec_IncrRecreatesExpiredStringWithoutTTLIndex'

@bootjp

bootjp commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bootjp, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 22050cc3-d1fe-4cab-ae30-d70d29141838

📥 Commits

Reviewing files that changed from the base of the PR and between e1890c5 and c0079c0.

📒 Files selected for processing (1)
  • docs/design/2026_04_17_partial_ttl_inline_value.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the design document docs/design/2026_04_17_partial_ttl_inline_value.md to reflect the current partial implementation status of embedding TTL directly in data values. It specifies that inline TTL is currently implemented only for Redis string values, while collection anchors still use the legacy secondary index. It also updates the status of various implementation phases, noting that Phase 0 and Phase 3 are implemented, while others remain as future work. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: c0079c0bf4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant