cli: add zstd import fallback via zstandard for Python < 3.14#5
Merged
Conversation
sascgc
force-pushed
the
main
branch
3 times, most recently
from
c880470 to
dbd802e
Compare
benjarobin
reviewed
Jul 1, 2026
benjarobin
requested changes
Jul 1, 2026
sascgc
force-pushed
the
main
branch
3 times, most recently
from
45a6323 to
3e30a1d
Compare
benjarobin
approved these changes
Jul 1, 2026
benjarobin
left a comment
benjarobin
left a comment
Collaborator
There was a problem hiding this comment.
I would prefer to have the zstd feature optional, but otherwise I am OK with the change
sascgc
force-pushed
the
main
branch
6 times, most recently
from
3346458 to
196736b
Compare
Member
|
In the case we make zstd support optional, then could we keep both backports.zstd and zstandard? |
sascgc
force-pushed
the
main
branch
3 times, most recently
from
dd11586 to
f651eb5
Compare
The zstandard package is widely available across distributions and Python environments, while backports.zstd is not always packaged or readily accessible. Add zstandard as a fallback import. Make the zstd support optional by deferring dependency checks until the feature is actually used. The zstandard backend does not support text mode when opening compressed files through zstd.open(). Switch to binary mode and let json.load() consume the resulting binary steam, which is supported by both backends. Signed-off-by: Christophe Guerreiro <christophe.guerreiro@non.se.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zstandard package is widely available across distributions and Python environments, while backports.zstd is not always packaged or readily accessible. So zstandard is added as import fallback.
The zstandard backend does not support text mode when opening compressed files through zstd.open().
Switch to binary mode and let json.load() consume the resulting binary steam, whcih is supported by both backends.