fix(mastra): emit tags as first-class Braintrust tags, not metadata#2212
Draft
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Draft
fix(mastra): emit tags as first-class Braintrust tags, not metadata#2212Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Conversation
buildMetadata placed exported.tags under metadata.tags, where Braintrust
does not surface them as tags. Move root-span tags to the top-level
`tags` row field (via ExperimentLogPartialArgs.tags) so they appear as
first-class, filterable tags. Matching @mastra/braintrust, tags are only
attached to the Mastra root span (Braintrust tags are trace-level).
Verified empirically that span.log({ tags }) writes the top-level tags
field while metadata.tags stays inert. Adds js/src/wrappers/mastra.test.ts.
Ports mastra-ai/mastra#12057 (re-fixes #9849).
Cedric / ViaDézo1er (viadezo1er)
force-pushed
the
cedric/tags-export
branch
from
5b13f4a to
a86388f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildMetadata placed exported.tags under metadata.tags, where Braintrust
does not surface them as tags. Move root-span tags to the top-level
tagsrow field (via ExperimentLogPartialArgs.tags) so they appear asfirst-class, filterable tags. Matching @mastra/braintrust, tags are only
attached to the Mastra root span (Braintrust tags are trace-level).
Verified empirically that span.log({ tags }) writes the top-level tags
field while metadata.tags stays inert. Adds js/src/wrappers/mastra.test.ts.
Ports mastra-ai/mastra#12057 (re-fixes #9849).