Fix Temporal replay span parent propagation#560
Open
Thibault Soubeste (thibaultsoubeste) wants to merge 1 commit into
Open
Fix Temporal replay span parent propagation#560Thibault Soubeste (thibaultsoubeste) wants to merge 1 commit into
Thibault Soubeste (thibaultsoubeste) wants to merge 1 commit into
Conversation
Member
|
hey Thibault Soubeste (@thibaultsoubeste) thank you for the PR! I will review this tomorrow and work on getting it merged + released asap afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Temporal replay parent propagation for workflows that schedule work after replay.
What was happening:
temporal.workflow.<Workflow>span.Fix:
max_cached_workflows=0, resumes by signal, and checks post-replay activities stay under the single workflow span both with and without a client parent.