LTS-2885: pin protobufjs to 7.6.4 (fix GHSA-xq3m-2v4x-88gg RCE)#13
Merged
Conversation
sourabhd-cbu
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ticket - https://browserstack.atlassian.net/browse/LTS-2885
Dependabot flagged a critical arbitrary-code-execution vulnerability in
protobufjs(GHSA-xq3m-2v4x-88gg, tracked internally as LTS-2885). The advisory: malicious type names in a protobuf schema definition can break out of protobufjs' runtime code generation and execute arbitrary JS during decode.This repo's
package-lock.jsonresolvesprotobufjs@7.5.3, which is< 7.5.5and therefore vulnerable.protobufjsis not a direct dependency — the sample's own code only uses@playwright/test. It comes in transitively through the BrowserStack SDK:Because it's transitive, Dependabot couldn't auto-open a bump PR — it needs an
overridespin, which is the same mechanism this repo already uses forqs,jws,tar-fs, etc.Change
package.json: add"protobufjs": "7.6.4"to the existingoverridesblockpackage-lock.json: regenerated so the pin takes effect (lockfileVersion 2preserved)7.6.4is the latest 7.x and is semver-compatible with the^7.2.5/^7.3.2constraints already in the tree.Impact
Pinning to
7.6.4resolves not just the critical GHSA-xq3m-2v4x-88gg but all open protobufjs advisories on this repo in one bump (#31 plus #38–#43, which need ≥ 7.5.6). After merge tomain, Dependabot re-scans and auto-resolves these alerts, closing LTS-2885.Verification
protobufjsresolves to7.6.4; dependency tree resolves cleanly with the override.protobufjs+ its@protobufjs/*helpers;@protobufjs/inquiredropped). No unrelated packages changed.@sampletags, Semgrep pin) intentionally left out.