LTS-4005: bump undici override 7.24.0 -> 7.28.0 (SOCKS5 TLS bypass CVE)#13
Open
dheeren-gaud wants to merge 1 commit into
Open
LTS-4005: bump undici override 7.24.0 -> 7.28.0 (SOCKS5 TLS bypass CVE)#13dheeren-gaud wants to merge 1 commit into
dheeren-gaud wants to merge 1 commit into
Conversation
) Patches SOCKS5 ProxyAgent TLS bypass (CVSS 7.4). The repo's existing overrides block pinned cheerio's undici to ^7.24.0, narrower than cheerio's own ^7.19.0 range. Raising the override floor to ^7.28.0 forces npm to pick the patched version while keeping intent documented. webdriver's nested undici stays on 6.x (not affected by the CVE; SOCKS5 support was introduced in undici 7.23.0). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProxyAgentsilently dropsrequestTlsoptions under SOCKS5, enabling MITM when cert pinning is in use.cheerio.undicioverride floor from^7.24.0to^7.28.0inpackage.json.undiciunder cheerio resolves to7.28.0(patched).webdriver's nested undici (6.x) is not affected — SOCKS5 support was added in undici7.23.0, so all6.xversions are immune.Why a package.json change (vs lock-only)
Unlike sister ticket LTS-4006, this repo has an
overridesblock that explicitly pinnedundicito a narrower range than cheerio itself declares. Updating the lock alone wouldn't suffice — npm respects the override boundary. Raising the floor to^7.28.0documents the security intent: anything below this is CVE-vulnerable.Exposure
Low in practice — this is example/sample code for customers. It doesn't run undici's
ProxyAgentwith SOCKS5 + custom CA pinning. Patching to satisfy the security SLA.Jira: https://browserstack.atlassian.net/browse/LTS-4005
Test plan
npm ls undicishowscheerio -> undici@7.28.0andwebdriver -> undici@6.27.0npm installfrom a clean state regenerates the same lock🤖 Generated with Claude Code