fix(wallet-toolbox): complete every local copy of a proven txid#280
Closed
ty-everett wants to merge 1 commit into
Closed
fix(wallet-toolbox): complete every local copy of a proven txid#280ty-everett wants to merge 1 commit into
ty-everett wants to merge 1 commit into
Conversation
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Production finding
A BRC-29 funding transaction was internalized concurrently by two recipient identities. The single
proven_tx_reqs.notify.transactionIdsJSON value ended with only two of the three local transaction IDs because concurrent read/merge/write updates were last-writer-wins. After Monitor acquired the proof, two transaction rows reachedcompletedand the omitted recipient remainedunproveneven though its outputs were confirmed network UTXOs.Fix
proven_txsrow already exists, so later Monitor events self-heal drift@bsv/wallet-toolbox2.4.2Validation
ts-standardpasses for both changed TypeScript filesProduction evidence: txid
2cdf4bb89c765d5b9fadef1c2bc4aceb2258ac607d0471e9df5f833bb08e6250; notify IDs omitted transaction 444915 while 444912 and 444918 completed.