Resolve symbolic Buildkite commit before import - #19
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fdf84-c346-73bc-ae96-2c241c02c5aa Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buildkite Hosted builds can leave
BUILDKITE_COMMIT=HEADin the command-hook context even after checkout resolved a concrete commit. Resolve invalid or symbolic values from the checked-out commit before launchingbuildkite-gha, while preserving an already-valid full lowercase SHA.The hook remains fail-closed if Git cannot resolve and verify a commit object or returns anything other than a lowercase 40-hex SHA.
Testing
bats testsshellcheck hooks/* lib/*git diff --check