Simplify repository checkout credentials - #21
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fdfc1-9b2d-764b-b31c-ce76721b3d3e Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
lox
force-pushed
the
simplify-repository-checkout-credentials
branch
from
August 8, 2026 09:59
10ffd7c to
471077f
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019fdfc1-9b2d-764b-b31c-ce76721b3d3e Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fdfc1-9b2d-764b-b31c-ce76721b3d3e Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion CLI change: buildkite/buildkite-gha#86
Summary
private-checkoutplugin configuration entirely--private-checkoutand the legacy--runtime-queue hostedoverride in release and source-ref modesbuildkite-gha upload <workflow>, regardless of repository-provider credential availability signalsCompatibility and security
This intentionally provides no backwards-compatibility shim. Because the plugin schema uses
additionalProperties: false, pipeline configurations that still setprivate-checkoutmust remove it.Repository checkout behavior is owned by
buildkite-ghaand Buildkite's repository-provider backend. The backend remains authoritative for whether credentials are issued for each concrete repository URL. Workflow permissions remain separate: checkout credentials do not populateGITHUB_TOKENorgithub.token, enable private actions, or permit alternate repositories or refs.Queue targeting is also owned by
buildkite-gha; supported Ubuntu runner labels continue to target Buildkite'shostedqueue without a plugin-supplied upload override.Tests
bats tests(24 tests), including true/false values for both repository-provider credential signals producing the exactupload <workflow>command without--runtime-queueor--private-checkoutshellcheck hooks/* lib/*bash -n hooks/* lib/*git diff --check