Skip to content

Simplify repository checkout credentials - #21

Merged
lox merged 3 commits into
mainfrom
simplify-repository-checkout-credentials
Aug 8, 2026
Merged

Simplify repository checkout credentials#21
lox merged 3 commits into
mainfrom
simplify-repository-checkout-credentials

Conversation

@lox

@lox lox commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Companion CLI change: buildkite/buildkite-gha#86

Summary

  • remove the private-checkout plugin configuration entirely
  • stop passing both --private-checkout and the legacy --runtime-queue hosted override in release and source-ref modes
  • always invoke buildkite-gha upload <workflow>, regardless of repository-provider credential availability signals
  • remove the obsolete private-checkout opt-in and compatibility documentation

Compatibility and security

This intentionally provides no backwards-compatibility shim. Because the plugin schema uses additionalProperties: false, pipeline configurations that still set private-checkout must remove it.

Repository checkout behavior is owned by buildkite-gha and Buildkite's repository-provider backend. The backend remains authoritative for whether credentials are issued for each concrete repository URL. Workflow permissions remain separate: checkout credentials do not populate GITHUB_TOKEN or github.token, enable private actions, or permit alternate repositories or refs.

Queue targeting is also owned by buildkite-gha; supported Ubuntu runner labels continue to target Buildkite's hosted queue without a plugin-supplied upload override.

Tests

  • bats tests (24 tests), including true/false values for both repository-provider credential signals producing the exact upload <workflow> command without --runtime-queue or --private-checkout
  • exact release, latest-source, and pinned-source invocation coverage
  • shellcheck hooks/* lib/*
  • bash -n hooks/* lib/*
  • git diff --check

@lox
lox force-pushed the simplify-repository-checkout-credentials branch from 10ffd7c to 471077f Compare August 8, 2026 09:59
ampagent and others added 2 commits August 8, 2026 10:02
Amp-Thread-ID: https://ampcode.com/threads/T-019fdfc1-9b2d-764b-b31c-ce76721b3d3e
Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fdfc1-9b2d-764b-b31c-ce76721b3d3e
Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
@lox
lox merged commit 1bc0e71 into main Aug 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants