Skip to content

fix: add rowKey for List#911

Merged
bvaughn merged 6 commits into
bvaughn:mainfrom
WofWca:rowKey
Jul 20, 2026
Merged

fix: add rowKey for List#911
bvaughn merged 6 commits into
bvaughn:mainfrom
WofWca:rowKey

Conversation

@WofWca

@WofWca WofWca commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Partially addresses #909.
Why partially? Because this doesn't add the prop
to the Grid component.

This is basically a (partial) cherry-pick of
3ffd43c.

Note that pnpm compile didn't work for me (couldn't connect to 3000).

Partially addresses bvaughn#909.
Why partially? Because this doesn't add the prop
to the `Grid` component.

This is basically a (partial) cherry-pick of
3ffd43c.

Co-authored-by: WofWca <wofwca@protonmail.com>
@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

@bvaughn is attempting to deploy a commit to the Brian Vaughn's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-window Ready Ready Preview Jul 20, 2026 5:03pm

@bvaughn

bvaughn commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Thanks for kicking off this PR. I've added Grid support as well as unit tests.

Note that pnpm compile didn't work for me (couldn't connect to 3000).

The "compile" script requires the dev server to be running (pnp dev) because it also crawls the site and compiles the local search index. No worries though, I've updated this stuff 😄

@bvaughn
bvaughn merged commit c48df31 into bvaughn:main Jul 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants