Remove dead cache from IndexSet#262
Open
fitzgen wants to merge 1 commit into
Open
Conversation
The `IndexSet::cache` field was never populated with a real value, and `cache.set()` was only ever called with the `(INVALID, 0)` sentinel, so the fast-path in `maybe_elem()` was unreachable and the invalidation stores in `elem()` and `maybe_elem_mut()` were pure-overhead on every `set`/`get`/`union_with`. Removing it additionally shrinks `IndexSet` by 16 bytes.
Member
Author
|
(FWIW, I also experimented with fixing the cache so that it would actually get populated, but it wasn't a speed up on Sightglass.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IndexSet::cachefield was never populated with a real value, andcache.set()was only ever called with the(INVALID, 0)sentinel, so the fast-path inmaybe_elem()was unreachable and the invalidation stores inelem()andmaybe_elem_mut()were pure-overhead on everyset/get/union_with. Removing it additionally shrinksIndexSetby 16 bytes.