Skip to content

Ensure reproducible builds when building with Bazel #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgeisler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure reproducible builds when building with Bazel #1640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ fn can_compile<T: AsRef<str>>(test: T) -> bool {
.arg("--target")
.arg(target)
.arg("-o")
.arg(out_file)
.arg(&out_file)
.stdout(Stdio::null()); // We don't care about the output (only whether it builds or not)

// If Cargo wants to set RUSTFLAGS, use that.
Expand All @@ -272,5 +272,12 @@ fn can_compile<T: AsRef<str>>(test: T) -> bool {

writeln!(child.stdin.take().unwrap(), "{}", test.as_ref()).unwrap();

child.wait().unwrap().success()
let success = child.wait().unwrap().success();

// The emitted metadata file is never read; only the exit status
// matters. Remove it to ensure reproducible builds with build
// systems like Bazel.
let _ = std::fs::remove_file(&out_file);

success
}
Loading