You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a revert of #10388 for the 34.0.0 release branch. That commit was the last commit in on the release branch and there should be no harm in deferring it for one extra release (stack-switching is still a work-in-progress on main) and the hope is that this reduces the risk/need to backport any changes.
cc @posborne sorry I should have cc'd you on this to start. I'm not dead-set on doing this I just figured it'd be a reasonable idea. If you would prefer to get this infrastructure landed on the release branch though I think it'd be reasonable to re-land. (and to clarify I have no intention of reverting on main, this was just to de-risk the release branch a little)
cc @posborne sorry I should have cc'd you on this to start. I'm not dead-set on doing this I just figured it'd be a reasonable idea. If you would prefer to get this infrastructure landed on the release branch though I think it'd be reasonable to re-land. (and to clarify I have no intention of reverting on main, this was just to de-risk the release branch a little)
No, I'm happy with this not being included on the release branch for this cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revert of #10388 for the 34.0.0 release branch. That commit was the last commit in on the release branch and there should be no harm in deferring it for one extra release (stack-switching is still a work-in-progress on
main) and the hope is that this reduces the risk/need to backport any changes.