fix(l1): guard SWR refresh commits against newer mutations (LAB-728) - #48
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Summary
Root cause
The merged SWR task committed through the ordinary unconditional write path, so a slow background result could overwrite a newer explicit write or resurrect a deletion. Moka's custom expiry also lacked update handling, which retained the original hard-expiry deadline, and freshness jitter was sampled on each hit.
The mutation guard is deliberately process-local, matching LAB-728's L1 serving-policy scope. Cross-instance invalidation remains outside this ticket.
Validation
cargo test --features cachekitio,redis,encryption,l1,macros,memcached,filecargo clippy --all-targets --features cachekitio,redis,encryption,l1,macros,memcached,file -- -D warningsKey/AAD/wire construction is unchanged; encryption and cross-SDK vector tests pass.
Documentation
Rust README and rustdoc now describe guarded completion, full-TTL renewal, fixed per-entry jitter, and the process-local boundary. Companion docs PR cachekit-io/docs#20 was updated and its Astro production build passes. Protocol matrix PR cachekit-io/protocol#43 remains accurate at its feature-summary level.