chore(deps): bump cachekit-core to 0.4.0 (LAB-902) - #53
Conversation
Encryption-only consumer; no envelope surface in this SDK (values stay plain MessagePack). Full CI matrix green locally: fmt, clippy -D warnings, tests incl. interop encryption vectors, wasm32 workers check, MSRV 1.85.
This comment has been minimized.
This comment has been minimized.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe cachekit crate updates its ChangesCachekit core dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ment The comment claimed 'cachekit-core 0.2 folds aes-gcm into the encryption feature on wasm32' while the pin three lines below now reads 0.4. The underlying fact is version-independent and still true at 0.4.0 (wasm is a pure alias for encryption), so the version token was the only part that could rot -- and bumping it to 0.4 would just re-rot at 0.5. De-hardcoding it follows the LAB-866 precedent, where the same class of pinned-version prose was removed from cachekit-core's README rather than updated. Raised independently by two reviewers on the LAB-902 expert panel.
d71b6a7
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Expert-panel review — crypto/protocol gate (LAB-902)The mandatory crypto/protocol expert panel (4 agents, high stakes) has run on this PR. The gate fires because the bump pulls a ByteStorage wire-format change ( Verdict: SHIP. One finding applied ( Crypto gate checkpoints — all CONFIRMED empirically
"Encryption-only consumer, zero envelope surface" — premise verified, not assumed. No Supply chain — clean. The crates.io artifact for No LAB-900 analogue. In cachekit-py the same bump silently broke an oversize-guard test whose premise rested on the old ~1.5× envelope inflation. That failure class is structurally impossible here: Finding applied
Findings rebutted — deliberately NOT applied
Items 1–3 are pre-existing conditions, not regressions introduced here. Flagging them so they are not lost; none blocks this PR. @coderabbitai review |
|
✏️ Learnings added
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Closes LAB-902 (parent LAB-764, stage 5).
Bump
cachekit-core0.3→0.4incrates/cachekit/Cargo.toml+ lockfile. cachekit-rs consumes core only for encryption (ZeroKnowledgeEncryptor, tenant key derivation insrc/encryption.rs); values remain plain MessagePack with no ByteStorage/StorageEnvelope surface — grep confirms envelope identifiers appear only in doc comments/tests asserting their absence.Local verification against 0.4.0 (mirrors CI):
cargo fmt --all -- --check✅cargo clippy --all-targets --features "cachekitio,redis,encryption,l1,macros,memcached,file" -- -D warnings✅cargo test --features "cachekitio,redis,encryption,l1,macros,memcached,file"✅ (all suites, incl. interop encryption round-trip vectors — byte-verified against protocol fixtures)cargo check --target wasm32-unknown-unknown --features workers,encryption --no-default-features✅cargo +1.85 check --all-targets --features "cachekitio,redis,encryption,l1,macros"✅ (MSRV)Redis/memcached live-service integration jobs left to CI (need running services).
Summary by CodeRabbit