fix: brownfield Gradle Plugin not to depend on *UpdatesResources task from expo-updates if absent#401
Open
artus9033 wants to merge 5 commits into
Open
fix: brownfield Gradle Plugin not to depend on *UpdatesResources task from expo-updates if absent#401artus9033 wants to merge 5 commits into
artus9033 wants to merge 5 commits into
Conversation
… from expo-updates if absent
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Brownfield Gradle plugin to avoid hard-depending on Expo Updates’ *UpdatesResources task when that task is not present, preventing Gradle task dependency resolution failures in Expo projects that don’t include expo-updates.
Changes:
- Make the plugin’s dependency on
create<Variant>UpdatesResourcesconditional on the task actually existing. - Bump the Brownfield Gradle plugin version (and related snapshot/version references) from
2.0.0-alpha02to2.0.0-alpha03. - Add a changeset entry for the patch and update release-notes test fixtures for the new version tag.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/generate-brownfield-gradle-plugin-release-notes.test.ts | Updates prerelease tag fixture and formatting to reflect the new alpha version. |
| packages/react-native-brownfield/src/expo-config-plugin/android/utils/constants.ts | Bumps the referenced Gradle plugin version used by the Expo config plugin. |
| gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/react/brownfield/processors/VariantTaskProvider.kt | Makes the *UpdatesResources dependency conditional to handle absence of expo-updates. |
| gradle-plugins/react/brownfield/gradle.properties | Bumps the Gradle plugin’s published version to 2.0.0-alpha03. |
| apps/scripts/prepare-android-build-gradle-for-ci.ts | Updates the snapshot version used for CI gradle preparation. |
| apps/RNApp/android/build.gradle | Updates the classpath snapshot version reference. |
| .changeset/fair-swans-remain.md | Adds a changeset documenting the fix as a patch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If using Expo and
expo-updatesis absent, the following error will be thrown:The solution is to depend on it only if it exists to cover use cases without expo-updates.