Ferric --verbose --concurrency and --clean - #332
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds three new command-line options to the ferric build tool to improve developer experience and control over build processes:
--verboseenables detailed output from underlying compilers and tools--concurrencylimits parallel build tasks (defaults to CPU count)--cleanremoves the target directory before building
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ferric/src/cargo.ts | Passes verbose flag to control cargo output mode and add target prefixes |
| packages/ferric/src/build.ts | Implements all three new options with concurrency control and improved logging |
| packages/cli-utils/src/index.ts | Exports p-limit for concurrency control |
| packages/cli-utils/package.json | Adds p-limit dependency |
| .changeset/evil-pens-shop.md | Documents cli-utils changes |
| .changeset/big-plums-write.md | Documents ferric-cli changes |
| ), | ||
| ), | ||
| ]), | ||
| { |
There was a problem hiding this comment.
The isSilent: verbose logic appears counterintuitive - when verbose mode is enabled, the spinner becomes silent. Consider renaming to make the relationship clearer, or add a comment explaining that verbose mode replaces the spinner with direct output.
Suggested change
| { | |
| { | |
| // In verbose mode, direct output replaces the spinner, so we silence it. |
kraenhansen
force-pushed
the
kh/ferric-verbose-concurrency-and-clean
branch
from
November 14, 2025 23:10
5678932 to
ae899b1
Compare
kraenhansen
force-pushed
the
kh/ferric-verbose-concurrency-and-clean
branch
from
November 14, 2025 23:12
ae899b1 to
5d05e45
Compare
This was referenced Aug 13, 2026
kraenhansen
pushed a commit
that referenced
this pull request
Aug 13, 2026
`ANDROID_STL` was hardcoded to `c++_shared` when configuring Android builds, with no escape hatch for an addon that needs `c++_static` or must match a prebuilt third-party dependency's STL (#418). The generic `-D`/`--define` cache-variable pass-through (added for #332, which #227 also asks for) already lets a consumer set arbitrary CMake cache variables, including `ANDROID_STL` - but it didn't actually work: our hardcoded Android defaults were appended to the CMake command line *after* the user-provided `-D` arguments, and CMake resolves a variable set multiple times via `-D` to its last occurrence, so the hardcoded value always won. Fix the ordering so the user's `--define` is applied last. `ANDROID_STL` still defaults to `c++_shared`, matching what React Native itself uses. Extract the CMake definitions building into an exported `buildCommonDefinitions` and add unit tests covering the default and the override precedence. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaK9eAAF5G8wj6UT8VekAm
kraenhansen
added a commit
that referenced
this pull request
Aug 13, 2026
`ANDROID_STL` was hardcoded to `c++_shared` when configuring Android builds, with no escape hatch for an addon that needs `c++_static` or must match a prebuilt third-party dependency's STL (#418). The generic `-D`/`--define` cache-variable pass-through (added for #332, which #227 also asks for) already lets a consumer set arbitrary CMake cache variables, including `ANDROID_STL` - but it didn't actually work: our hardcoded Android defaults were appended to the CMake command line *after* the user-provided `-D` arguments, and CMake resolves a variable set multiple times via `-D` to its last occurrence, so the hardcoded value always won. Fix the ordering so the user's `--define` is applied last. `ANDROID_STL` still defaults to `c++_shared`, matching what React Native itself uses. Extract the CMake definitions building into an exported `buildCommonDefinitions` and add unit tests covering the default and the override precedence. Claude-Session: https://claude.ai/code/session_01DaK9eAAF5G8wj6UT8VekAm Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging this PR will add three options to
ferric:--verboseoutputs more to the terminal while building--concurrencyputs a limit on the number of concurrent sub-command invocations--cleandeletes thetarget(build) directory before building