Skip to content

ci: stop piping the macOS xcodebuild through xcbeautify #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraenhansen merged 2 commits into from
Aug 10, 2026
Merged

ci: stop piping the macOS xcodebuild through xcbeautify #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d5868e
ci: stop piping the macOS xcodebuild through xcbeautify
kraenhansen Aug 10, 2026
6495d95
ci: note the macOS job's tracking issue on its label gate
kraenhansen Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ jobs:
working-directory: apps/test-app
test-macos:
# Disabling this on main for now, as initializing the template takes a long time and
# we don't have macOS-specific code yet
# we don't have macOS-specific code yet. Currently also blocked on react-native-macos:
# https://github.com/callstackincubator/react-native-node-api/issues/392
if: contains(github.event.pull_request.labels.*.name, 'MacOS 💻')
name: Test app (macOS)
runs-on: macos-latest
Expand Down Expand Up @@ -222,8 +223,7 @@ jobs:
run: npx react-native bundle --entry-file index.js --platform macos --dev false --minify false --bundle-output dist/main.macos.jsbundle --assets-dest dist/res
working-directory: apps/macos-test-app
- name: Build test app
# pipefail so an xcodebuild failure is not masked by xcbeautify's exit code
run: set -o pipefail && xcodebuild archive -workspace MacOSTestApp.xcworkspace -configuration Release -scheme MacOSTestApp-macOS -destination generic/platform="macOS" -archivePath ./build/macos-test-app.xcarchive | xcbeautify
run: xcodebuild archive -workspace MacOSTestApp.xcworkspace -configuration Release -scheme MacOSTestApp-macOS -destination generic/platform="macOS" -archivePath ./build/macos-test-app.xcarchive
working-directory: apps/macos-test-app/macos
- name: Run test app
run: npx mocha-remote --exit-on-error -- macos/build/macos-test-app.xcarchive/Products/Applications/MacOSTestApp.app/Contents/MacOS/MacOSTestApp
Expand Down
Loading