ci: bring host-cpp-tests in line with the rest of the workflow - #408
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
host-cpp-tests was added on next (#398), so the Node.js 20 deprecation sweep on main (#405, #407) never reached it: it is the one job in the workflow still on actions/checkout@v4, pnpm/action-setup@v4 and actions/setup-node@v6, and so the only remaining source of the runner's "targets Node.js 20" warning. Merges main to pick up #407 and gives the job the same arrangement as its siblings: Node.js set up before pnpm, pnpm/action-setup v6 owning the store cache, and ccache-action pinned to an exact patch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W14eEfXdK5DYzv43MazryE
check.yml only runs on opened/synchronize/reopened, so the host-gated job this change is about does not start from labelling alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W14eEfXdK5DYzv43MazryE
kraenhansen
force-pushed
the
claude/nodejs-20-deprecation-next-ubspbg
branch
from
August 12, 2026 10:55
5d25636 to
a7e67a6
Compare
kraenhansen
added a commit
that referenced
this pull request
Aug 13, 2026
* ci: bring host-cpp-tests in line with the rest of the workflow host-cpp-tests was added on next (#398), so the Node.js 20 deprecation sweep on main (#405, #407) never reached it: it is the one job in the workflow still on actions/checkout@v4, pnpm/action-setup@v4 and actions/setup-node@v6, and so the only remaining source of the runner's "targets Node.js 20" warning. Merges main to pick up #407 and gives the job the same arrangement as its siblings: Node.js set up before pnpm, pnpm/action-setup v6 owning the store cache, and ccache-action pinned to an exact patch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W14eEfXdK5DYzv43MazryE * ci: re-run checks for the newly applied labels check.yml only runs on opened/synchronize/reopened, so the host-gated job this change is about does not start from labelling alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W14eEfXdK5DYzv43MazryE --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #405 and #407, which swept the Node.js 20 deprecation out of the workflows on
main.host-cpp-testswas added onnext(#398), so it was never in the diff of either sweep. It is the one job incheck.ymlstill onactions/checkout@v4,pnpm/action-setup@v4andactions/setup-node@v6— and therefore the only remaining source of the runner's "targets Node.js 20 but are being forced to run on Node.js 24" warning anywhere in the repo.Changes
Gives
host-cpp-teststhe same arrangement its seven siblings already have onnext:plus
hendrikmuhs/ccache-actionpinned tov1.2.23, since its floatingv1/v1.2tags still resolve to a Node.js 20 build.Node.js is set up before pnpm rather than after — the reasoning is in the note at the top of
check.yml. Short version: v6 bootstraps pnpm vianpm ciand resolvesnpmthroughPATH, so it needs a working npm ahead of the broken copy in the self-hosted runner's Node.js 24 externals. That ordering used to be impossible becausesetup-node'scache: pnpmshells out topnpm store path; v6 caches the store itself, so the constraint is gone.After this, all eight jobs in
check.ymlshare the same first three steps.Notes
host-cpp-testsis gated on thehostlabel for pull requests, so that label is applied here to actually exercise the change on all three runners.