fix(host): make vendor-hermes --silent actually silent - #410
Merged
Conversation
kraenhansen
force-pushed
the
claude/vendor-hermes-silent-flag
branch
from
August 12, 2026 13:20
dbd5585 to
407f7ee
Compare
The spinners were passed `isEnabled: !silent`. A disabled ora spinner still writes `- <text>` on start and the success/fail symbol on completion (to stderr) — it only skips the animation. `isSilent` is the option that suppresses output entirely. Callers capture stdout only (`$(... --silent)` in CI and the Gradle error message, backticks in patch-hermes.rb), so the stray output was noise rather than a broken path, but `--silent` now does what it says. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HX4imsygeawVtsmoP1sj3F
kraenhansen
force-pushed
the
claude/vendor-hermes-silent-flag
branch
from
August 12, 2026 13:29
407f7ee to
8ecd6a5
Compare
kraenhansen
added a commit
that referenced
this pull request
Aug 13, 2026
The spinners were passed `isEnabled: !silent`. A disabled ora spinner still writes `- <text>` on start and the success/fail symbol on completion (to stderr) — it only skips the animation. `isSilent` is the option that suppresses output entirely. Callers capture stdout only (`$(... --silent)` in CI and the Gradle error message, backticks in patch-hermes.rb), so the stray output was noise rather than a broken path, but `--silent` now does what it says. Claude-Session: https://claude.ai/code/session_01HX4imsygeawVtsmoP1sj3F Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor-hermes --silentpassedisEnabled: !silentto its spinners. In ora, adisabled spinner is not a silent one —
start()still writes- <text>andstopAndPersist()still writes the success/fail symbol, both to stderr; onlythe animation is skipped.
isSilent: truereturns early from both.Verified against the installed ora 8.2.0:
Every caller captures stdout only —
$(pnpm exec react-native-node-api vendor-hermes --silent)incheck.ymland in the Gradle error message frompackages/host/android/build.gradle, and the backticks inpackages/host/scripts/patch-hermes.rb— so this was stray output rather than acorrupted path. The flag now does what it documents.
Picked out of the long-stale #188, which proposed the same change against code
that has since been rewritten.
Generated by Claude Code