Skip to content

cmake-rn: make CODE_SIGNING_ALLOWED configurable for Apple builds #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraenhansen merged 1 commit into from
Aug 13, 2026
+18 −5
Merged

cmake-rn: make CODE_SIGNING_ALLOWED configurable for Apple builds #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silly-cobras-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"cmake-rn": minor
---

Add a `--code-signing-allowed` flag to `cmake-rn`. `CODE_SIGNING_ALLOWED=NO` remains the default (needed for the free-standing dynamic libraries we produce), but a consumer who needs signed binaries in the XCFramework can now pass `--code-signing-allowed` to opt in.
18 changes: 13 additions & 5 deletions packages/cmake-rn/src/platforms/apple.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,15 @@ const appleBundleIdentifierOption = new Option(
"Unique CFBundleIdentifier used for Apple framework artifacts",
).default(undefined, "com.callstackincubator.node-api.{libraryName}");

const codeSigningAllowedOption = new Option(
"--code-signing-allowed",
"Allow code signing when building free dynamic libraries (passed as CODE_SIGNING_ALLOWED to xcodebuild)",
).default(false);

type AppleOpts = {
xcframeworkExtension: boolean;
appleBundleIdentifier?: string;
codeSigningAllowed: boolean;
};

function getBuildPath(baseBuildPath: string, triplet: Triplet) {
Expand Down Expand Up @@ -259,7 +265,8 @@ export const platform: Platform<Triplet[], AppleOpts> = {
amendCommand(command) {
return command
.addOption(xcframeworkExtensionOption)
.addOption(appleBundleIdentifierOption);
.addOption(appleBundleIdentifierOption)
.addOption(codeSigningAllowedOption);
},
assertValidTriplets(triplets) {
for (const suffix of SIMULATOR_TRIPLET_SUFFIXES) {
Expand Down Expand Up @@ -366,7 +373,7 @@ export const platform: Platform<Triplet[], AppleOpts> = {
},
async build(
{ spawn, triplet },
{ build, target, configuration, appleBundleIdentifier },
{ build, target, configuration, appleBundleIdentifier, codeSigningAllowed },
) {
// We expect the final application to sign these binaries
if (target.length > 1) {
Expand Down Expand Up @@ -440,9 +447,10 @@ export const platform: Platform<Triplet[], AppleOpts> = {
...(target.length > 0 ? ["--target", ...target] : []),
"--",

// Skip code-signing (needed when building free dynamic libraries)
// TODO: Make this configurable
"CODE_SIGNING_ALLOWED=NO",
// Skip code-signing by default (needed when building free dynamic
// libraries), but let a consumer opt into signed binaries via
// --code-signing-allowed.
`CODE_SIGNING_ALLOWED=${codeSigningAllowed ? "YES" : "NO"}`,
]);
// Create a framework
const { artifacts } = sharedLibrary;
Expand Down
Loading