BINFR-6469: identify view bookmarks by node.key instead of boardId#387
Closed
Manjinder Singh (manjindersingh98) wants to merge 2 commits into
Closed
BINFR-6469: identify view bookmarks by node.key instead of boardId#387Manjinder Singh (manjindersingh98) wants to merge 2 commits into
Manjinder Singh (manjindersingh98) wants to merge 2 commits into
Conversation
The blueprint bookmark import/export endpoints now key off the stable node key (rootNodeKey + key) instead of the boardId, which is regenerated during a team-to-team copy. Update the view-bookmarks pull/push commands to pass --rootNodeKey and --key, build the request URLs with those params, and name the export file after the node key. Requires the matching blueprint change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Manjinder Singh (manjindersingh98)
requested a review
from a team
as a code owner
Match the blueprint endpoint rename: the view-bookmarks commands now use a --rootNodeKeyWithBoardKey flag and send it as the rootNodeKeyWithBoardKey query param alongside --key. Both parts are required since a board key is not unique across teams. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
I'm closing the PR as Roberto Welzel Filho (@roberto-welzel) is going forward with an asset Id to key map to solve the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The blueprint bookmark import/export endpoints now key off the stable node key (
rootNodeKey+key) instead ofboardId, which is regenerated during a team-to-team copy. This updates theview-bookmarkscommands accordingly so the same command works across teams (e.g. after a T2T copy).Changes
pull view-bookmarks/push view-bookmarks: replace--id <boardId>with required--rootNodeKey <rootNodeKey>and--key <key>.rootNodeKey+keyparams; name the export filestudio_view_bookmarks_<rootNodeKey>.<key>.json.Requires the matching blueprint endpoint change (celonis/blueprint#3234) — must be released together.
Out of scope
Analysis bookmarks (
pull/push bookmarks) hitprocess-analytics, not blueprint — unchanged.Testing
npx jest tests/commands/view(8 passing);tsc --noEmitclean.Jira: BINFR-6469 (epic BINFR-6385)
🤖 Generated with Claude Code
Note
Medium Risk
Breaking CLI contract and coordinated release with blueprint; scope is limited to view-bookmarks only.
Overview
Breaking change:
pull view-bookmarksandpush view-bookmarksno longer accept--id(board UUID). They now require--rootNodeKeyWithBoardKeyand--keyso views are addressed by stable Studio node keys that survive team-to-team copies.Blueprint bookmark import/export URLs are built with
rootNodeKeyWithBoardKeyandkeyquery params instead ofboardId. Pulled files are namedstudio_view_bookmarks_<rootNodeKeyWithBoardKey>.<key>.json. The same parameters are threaded through the CLI module, command service, manager factory, and manager; user docs and view command tests are updated to match.This must ship together with the matching blueprint API change; analysis bookmark commands are unchanged.
Reviewed by Cursor Bugbot for commit 879cab3. Bugbot is set up for automated code reviews on this repo. Configure here.