Skip to content

Add: cargo-semver-checks - #161

Open
ReinierMaas wants to merge 3 commits into
masterfrom
reinier/cargo-semver-checks
Open

Add: cargo-semver-checks#161
ReinierMaas wants to merge 3 commits into
masterfrom
reinier/cargo-semver-checks

Conversation

@ReinierMaas

Copy link
Copy Markdown
Contributor

This should prevent us from making semver incompatible changes without a required version bump.

@ReinierMaas ReinierMaas self-assigned this Jul 30, 2026
This should prevent us from making semver incompatible changes without a required version bump.
@ReinierMaas
ReinierMaas force-pushed the reinier/cargo-semver-checks branch from 7f00edf to d1cd789 Compare July 31, 2026 08:58
@ReinierMaas
ReinierMaas force-pushed the reinier/cargo-semver-checks branch from c0c2fea to 46a5312 Compare July 31, 2026 11:37
@ReinierMaas
ReinierMaas requested a review from jerbaroo July 31, 2026 11:54

@jerbaroo jerbaroo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread justfile
#!/usr/bin/env bash
set -euo pipefail
export DATABASE_URL="sqlite://{{justfile_directory()}}/opsqueue/opsqueue_example_database_schema.db"
cargo semver-checks --workspace --target x86_64-unknown-linux-gnu --baseline-rev "$(git tag -l --sort=-version:refname | head -1)"

@jerbaroo jerbaroo Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a comment here: "We select the highest numbered git TAG as the baseline to compare against, which is not necessarily the most recent Cargo version."

Comment thread .github/workflows/ci.yml
- uses: actions/checkout@0c366fd6a839edf440554fa01a7085ccba70ac98
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # Latest as of 2026-07-31
with:
fetch-tags: "true"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment why we do this here e.g. because the semver checks need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants