Build from source some extensions that were previously bundled. by rgrunber · Pull Request #775 · che-incubator/che-code

rgrunber · 2026-07-29T03:37:23Z

devfile.vscode-devfile, ms-vscode.js-debug, js-debug-companion, js-profile-table
Create git submodules under extensions/
Add extensions to code/build/npm/dirs.ts to trigger npm-install
Create .esbuild.ts to wrap compilation process of each extension

Assisted-By: claude-opus-4-6

I tested this by publishing to https://quay.io/repository/rgrunber/che-code?tab=tags and then running that editor image. The extensions seem to be bundled as part of the editor.

The only thing I need to verify is that the contents of the published vsix in the marketplace match the contents (roughly) of what the build generates. ~~I think the .vscodeignore includes too many things which would result in a larger installation.~~ ✔️

Here is how this works :

In the commit Add js-debug, js-debug-companion, js-profile-visualizer & devfile., I have copied the latest tagged versions of those projects, into code/extensions/. In, Minor modifications to extensions for successful builds. I have made small modifications to ensure these projects can successfully run npm install. Some of these changes could probably be upstreamed, but for now they live in a separate commit.

The final phase involves adding the projects to code/npm/dirs.ts to ensure npm install is called on each folder, and creating an .esbuild.ts file in the root of each project, to wrap the compilation process of each extension. The compilation setup is done as part of preinstall, and it can be seen in code/build/copy-extension-build-scripts.js

github-actions · 2026-07-29T03:37:30Z

Click here to review and test in web IDE:

coderabbitai · 2026-07-29T03:43:02Z

📝 Walkthrough

Walkthrough

The change adds four Git submodules and enables submodule checkout in both build workflows. Install hooks copy extension build scripts and update js-debug metadata. New scripts build the Devfile, JavaScript debugging, and profiling extensions. Gulp and npm build configuration includes these extensions. Built-in extension metadata and locked extension artifacts are removed.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Checkout
  participant NpmInstall
  participant BuildScripts
  participant ExtensionRepositories
  Checkout->>ExtensionRepositories: fetch submodules
  NpmInstall->>BuildScripts: run preinstall helpers
  BuildScripts->>ExtensionRepositories: copy build scripts and update metadata
  BuildScripts->>ExtensionRepositories: invoke extension builds
  ExtensionRepositories-->>BuildScripts: generate build outputs

Suggested reviewers: azatsarynnyy, vitaliy-guliy, romannikitenko

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Rebase Rules For Upstream Changes	❌ Error	The PR changes multiple non-exempt upstream files under code/, but `git diff` shows no `.rebase/` or `.rebase/CHANGELOG.md` changes; the required rebase rules and changelog entry are missing.	Add rebase rules for the upstream changes, document all affected paths in `.rebase/CHANGELOG.md`, and add or update `rebase.sh` conflict routing for those rules.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise, uses imperative mood, and clearly describes building previously bundled extensions from source.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

code/build/npm/dirs.ts (1)
31-46: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Ensure the npm cache contract matches these added dirs.

extensions/devfile is a TypeScript build target but has no package.json/package-lock.json, so it is exposed to the cache logic without the files it expects; either add a no-op package contract or move it out of this npm dir list. Similarly, extensions/js-profile-visualizer compiles nested packages/vscode-js-profile-table; if that package depends on its own install artifacts, add entries/lockfile handling for the nested package too.
[mantainability_and_code_quality]
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@code/build/npm/dirs.ts` around lines 31 - 46, Update the npm directory
configuration containing the listed extension paths so every cached build target
has the package artifacts expected by the cache logic. For extensions/devfile,
either add the required no-op package contract or remove it from the npm
directory list; for extensions/js-profile-visualizer, include handling for the
nested packages/vscode-js-profile-table package and its lockfile when required.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/image-publish.yml:
- Around line 39-40: Update the actions/checkout configuration by adding
persist-credentials: false alongside submodules: true, ensuring credentials are
not retained in the workspace before the subsequent Docker build.

In `@code/build/copy-extension-build-scripts.js`:
- Around line 34-42: Update the missing-input checks in the copy flow, including
the checks for src, destDir, and jsDebugPkgPath, to throw an error immediately
instead of warning and continuing. Preserve the existing path-specific error
context while ensuring any absent required submodule directory, build script, or
js-debug package metadata causes the script to fail.

In `@code/build/extension-build-scripts/js-profile-visualizer.esbuild.ts`:
- Around line 14-23: Update the two tsc invocations in the build script so
catches do not unconditionally continue after compiler failures. Allow only
explicitly tolerated type-check errors, or validate that all expected out/esm
outputs were freshly generated before proceeding; otherwise propagate the
failure and prevent packaging an invalid extension.

---

Outside diff comments:
In `@code/build/npm/dirs.ts`:
- Around line 31-46: Update the npm directory configuration containing the
listed extension paths so every cached build target has the package artifacts
expected by the cache logic. For extensions/devfile, either add the required
no-op package contract or remove it from the npm directory list; for
extensions/js-profile-visualizer, include handling for the nested
packages/vscode-js-profile-table package and its lockfile when required.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 71a74af2-86ee-4e51-8b8e-a09ae7d4786e

📥 Commits

Reviewing files that changed from the base of the PR and between d2d7be6 and 21dd277.

📒 Files selected for processing (18)

.github/workflows/image-publish.yml
.gitmodules
build/artifacts/artifacts.lock.yaml
code/build/copy-extension-build-scripts.js
code/build/extension-build-scripts/devfile.esbuild.ts
code/build/extension-build-scripts/js-debug-companion.esbuild.ts
code/build/extension-build-scripts/js-debug.esbuild.ts
code/build/extension-build-scripts/js-profile-visualizer.esbuild.ts
code/build/extension-build-scripts/js-profile-visualizer.webpack.override.js
code/build/gulpfile.extensions.ts
code/build/npm/dirs.ts
code/extensions/devfile
code/extensions/js-debug
code/extensions/js-debug-companion
code/extensions/js-profile-visualizer
code/package.json
code/product.json
package.json

💤 Files with no reviewable changes (2)

code/product.json
build/artifacts/artifacts.lock.yaml

github-actions · 2026-07-29T05:46:08Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-775-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-775-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-775-dev-amd64

tolusha · 2026-08-04T10:13:29Z

Hi! I'm che-ai-assistant — I help with your pull requests.

I check for new comments every 10m0s, so there may be a short delay before I respond.

Available commands:

/che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
/che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
/che-ai-assistant ok-pr-readiness — Ensure PR has validation steps
/che-ai-assistant check-pr-test-failures — Analyze failing CI checks, identify root causes, and suggest fixes
/che-ai-assistant update-che-e2e-tests — Update Eclipse Che e2e tests
/che-ai-assistant claude — Run a free-form instruction on this PR
/che-ai-assistant help — Show this help message

coderabbitai · 2026-08-11T19:11:04Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pull-request-check.yml:
- Around line 57-58: Update the actions/checkout configuration in the workflow’s
with block to set persist-credentials to false, while preserving the existing
submodules setting, unless a later workflow step explicitly requires Git
authentication.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c8e5e8d-04c6-4deb-ae75-67249fa6b6a1

📥 Commits

Reviewing files that changed from the base of the PR and between 70ba2e7 and 2a9dd85.

📒 Files selected for processing (19)

.github/workflows/image-publish.yml
.github/workflows/pull-request-check.yml
.gitmodules
build/artifacts/artifacts.lock.yaml
code/build/copy-extension-build-scripts.js
code/build/extension-build-scripts/devfile.esbuild.ts
code/build/extension-build-scripts/js-debug-companion.esbuild.ts
code/build/extension-build-scripts/js-debug.esbuild.ts
code/build/extension-build-scripts/js-profile-visualizer.esbuild.ts
code/build/extension-build-scripts/js-profile-visualizer.webpack.override.js
code/build/gulpfile.extensions.ts
code/build/npm/dirs.ts
code/extensions/devfile
code/extensions/js-debug
code/extensions/js-debug-companion
code/extensions/js-profile-visualizer
code/package.json
code/product.json
package.json

💤 Files with no reviewable changes (2)

code/product.json
build/artifacts/artifacts.lock.yaml

🚧 Files skipped from review as they are similar to previous changes (11)

code/package.json
code/extensions/js-debug-companion
code/build/extension-build-scripts/devfile.esbuild.ts
code/build/extension-build-scripts/js-debug-companion.esbuild.ts
code/extensions/js-profile-visualizer
.gitmodules
code/build/extension-build-scripts/js-profile-visualizer.webpack.override.js
code/extensions/js-debug
code/build/gulpfile.extensions.ts
code/extensions/devfile
package.json

github-actions · 2026-08-11T19:55:28Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-775-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-775-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-775-dev-amd64

- devfile 0.0.4 - js-debug 1.117.0 - js-debug-companion 1.1.3 - js-profile-visualizer 1.0.11 (exclude packages/vscode-js-profile-flame) Signed-off-by: Roland Grunberg <rgrunber@redhat.com>

- es5-ext -> @unes/es5-ext in overrides - Remove playwright dependency from js-debug (script requires root) - Update @types/node 20.9.0 -> 20.19.0 in js-profile-visualizer to correctly resolve dependencies - Remove packages/vscode-js-profile-flame from workspace field - Reduce extension size for js-debug by using .vscodeignore Signed-off-by: Roland Grunberg <rgrunber@redhat.com>

- devfile.vscode-devfile, ms-vscode.js-debug, js-debug-companion, js-profile-table - Add extensions to code/build/npm/dirs.ts to trigger npm-install - Create .esbuild.ts to wrap compilation process of each extension Assisted-By: claude-opus-4-6 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>

github-actions · 2026-08-13T21:17:49Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-775-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-775-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-775-dev-amd64

rgrunber · 2026-08-14T13:02:04Z

+  architecture: process.arch,
+};
+
+const jsDebugRegisteredToken = '$jsDebugIsRegistered';


Consider adding // notsecret here.

rgrunber requested review from RomanNikitenko, azatsarynnyy and vitaliy-guliy as code owners July 29, 2026 03:37

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread .github/workflows/image-publish.yml Outdated

Comment thread code/build/copy-extension-build-scripts.js

Comment thread code/build/extension-build-scripts/js-profile-visualizer.esbuild.ts

rgrunber force-pushed the bundled-artifacts branch from 21dd277 to 871ed3b Compare July 29, 2026 03:58

rgrunber changed the title ~~Build from source some extensions that were previous bundled.~~ Build from source some extensions that were previously bundled. Jul 29, 2026

rgrunber force-pushed the bundled-artifacts branch from 871ed3b to 2a9dd85 Compare August 11, 2026 19:10

coderabbitai Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread .github/workflows/pull-request-check.yml Outdated

rgrunber added 3 commits August 13, 2026 14:09

Add js-debug, js-debug-companion, js-profile-visualizer & devfile.

75e643c

- devfile 0.0.4 - js-debug 1.117.0 - js-debug-companion 1.1.3 - js-profile-visualizer 1.0.11 (exclude packages/vscode-js-profile-flame) Signed-off-by: Roland Grunberg <rgrunber@redhat.com>

rgrunber force-pushed the bundled-artifacts branch from 2a9dd85 to b1d1c3d Compare August 13, 2026 20:36

rgrunber commented Aug 14, 2026

View reviewed changes

Uh oh!

Conversation

rgrunber commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

tolusha commented Aug 4, 2026

Uh oh!

coderabbitai Bot commented Aug 11, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 13, 2026

Uh oh!

rgrunber Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rgrunber commented Jul 29, 2026 •

edited

Loading

github-actions Bot commented Jul 29, 2026 •

edited

Loading

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading