Feature/generic dist - #494
Merged
Merged
Conversation
move Maxwellian tests from test_maxwellian.py to test_distribution.py
jacklovell
requested changes
Jul 13, 2026
jacklovell
left a comment
jacklovell
left a comment
Member
There was a problem hiding this comment.
Looks good. Can you fix the merge conflict in the changelog and address one small comment in the test file? Good to see that ZeroDistribution is now properly documented too.
jacklovell
approved these changes
Jul 21, 2026
…ature/generic_dist
Member
Author
|
I updated the tests to import the constants from cherab. I also fixed one doctring problem and the merge conflict problem. This PR is ready for a new review. |
jacklovell
reviewed
Jul 31, 2026
jacklovell
reviewed
Aug 3, 2026
jacklovell
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
GenericDistributionsublcass ofDistributionFunction, related to #481.Allows users to build arbitrary particle distribution functions using the Raysect & Cherab function framework.