Skip to content

Pull request#4

Open
battika wants to merge 5 commits into
chok:masterfrom
battika:master
Open

Pull request#4
battika wants to merge 5 commits into
chok:masterfrom
battika:master

Conversation

@battika

@battika battika commented Jan 12, 2012

Copy link
Copy Markdown

Hello,

Please accept my pull request which does two things:

  1. Logs a message when curl fails to execute
  2. Includes a copy of a cacert file in the curl request when dev environment is Windows. In case of Linux the file will not be included.

Any questions please contact me.

Thanks in advance,
Attila

@chok

chok commented Mar 25, 2012

Copy link
Copy Markdown
Owner

Hi,

Sorry for the wait...

To log the curl error I completely agree but for Windows maybe some of people who use windows don't have this kind of problem. I think it should be better to add an option related to curl to specify the cacert file and why not bundle it and specify in the readme that for Windows user it is possible to have problems and how fix it.

What do you think about that ?

Thanks
Maxime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants