[codex] integrate upstream shortest-path catalog and headless transport tests - #1825
Draft
chsami wants to merge 2 commits into
Draft
[codex] integrate upstream shortest-path catalog and headless transport tests#1825chsami wants to merge 2 commits into
chsami wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Microbot's web walker was missing transport and collision coverage available in the upstream shortest-path project. Transport behavior also depended heavily on logged-in runtime testing. This change imports a pinned, reviewable catalog and adds side-effect-free coverage for route selection and transport requirements.
Impact
The web walker can consider the expanded transport catalog while preserving Microbot-specific execution handlers and configuration. Developers can validate membership, skill, quest, varbit, item, equipment, currency, teleport, and transport-selection behavior offline. Live smoke tests are still required for scene objects, NPCs, widgets, dialogue, animation timing, and other dynamic game contracts.
Validation
./gradlew :client:compileJava./gradlew :client:runUnitTests --tests 'net.runelite.client.plugins.microbot.shortestpath.HeadlessTransportHarnessTest'