test: add legacy-data upgrade-path integration test to CI

[humble-little-bear]

Summary

Adds a CI integration test that simulates a real user upgrading offckb: a devnet created by an old offckb release (0.3.4, which ships CKB 0.113.1) must keep working when the current build operates on that legacy data. This guards the upgrade path that today has zero automated coverage — CI runners always start from a clean environment, so legacy-data regressions (like the ckb.toml Terminal RPC migration bug that previously reached users before we noticed) can only be caught by users.

How it works

scripts/legacy-data-test.sh runs entirely inside a sandboxed HOME/XDG directory (never touches the developer's real offckb data):

1. Install @offckb/cli@0.3.4 from npm, start its node (CKB 0.113.1), mine some blocks, send a transfer, stop it.
2. Run the current build (pnpm build output) against that same data directory and assert:
   • The chain continues — same genesis hash, tip grows past the old tip. (A bare "RPC responds" check would let a silent chain reset pass.)
   • The legacy ckb.toml is migrated — Terminal RPC module added + tcp_listen_address enabled (required by offckb status / ckb-tui). This is the exact class of bug that historically shipped to users undetected.
   • The bundled chain spec (specs/dev.toml) stays byte-identical — initChainIfNeeded must never overwrite an existing devnet config.
   • A fresh transfer succeeds and is committed on the upgraded chain.

The script header carries a CONVENTION note: any future feature that changes how offckb writes/migrates devnet config must extend these assertions, so "new config stays compatible with old data" is enforced institutionally rather than by memory.

CI changes

• New step in .github/workflows/test.yml, ubuntu-latest only, per-PR: the test is OS-independent (config/data compatibility) and downloads an extra legacy CKB binary, so one platform keeps the signal cheap. Adds ~1 min to the ubuntu job.
• npm cache (~/.npm) is cached to keep the legacy CLI install fast.
• Runs before create-test.sh: create-test's teardown only kills the pnpm wrapper and leaves CKB processes holding ports 8114/28114 until job end, which trips the legacy test's precondition check. The legacy test's own teardown is complete, so create-test still starts on free ports. (The orphaned-process issue in create-test is worth a separate fix.)
• package.json gets a test:legacy-data script; changeset included (test/CI infra only, no runtime changes).

Verification

• Verified end-to-end locally twice (offckb 0.3.4 → 0.4.10 build).
• CI on this PR: the new step ran and passed (~70s), all checks green on ubuntu/macos/windows.

[coderabbitai]

Warning

Review limit reached

@humble-little-bear, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 189a91ba-ba84-4aac-8fe4-cd39c9a1a465

📥 Commits

Reviewing files that changed from the base of the PR and between 966926b and c2c6f50.

📒 Files selected for processing (4)

• .changeset/legacy-data-upgrade-test.md
• .github/workflows/test.yml
• package.json
• scripts/legacy-data-test.sh

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}