refactor(admin-roles): migrate from server#2205
Conversation
shikanime
added
technical debt
|
🤖 Hey ! The security scan report for the current pull request is available here. |
9732d98 to
a6fb16f
Compare
6f5e810 to
863e72d
Compare
072e499 to
98d9d04
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
cad00e2 to
2199b21
Compare
98d9d04 to
4b1836d
Compare
4b1836d to
3cd401d
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
| ## 🎯 Progression globale | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
thought: Le site s'est fait highjacked, apparemment: https://progress-bar.dev/24/?title=modularisation&width=400 😓
Faudrait virer ça, c'était gadget de toute façon
| } | ||
|
|
||
| if (positionsAvailable.length && positionsAvailable.length !== dbRoles.length) { | ||
| throw new BadRequestException('Les numéros de position des rôles sont incohérentes') |
There was a problem hiding this comment.
suggestion:
| throw new BadRequestException('Les numéros de position des rôles sont incohérentes') | |
| throw new BadRequestException('Les numéros de position des rôles sont incohérents') |
Ce sont soit les numéros qui sont incohérents, soit les positions qui sont incohérentes, mais pas les deux en même temps 😅
7ffacd8 to
c4ed596
Compare
|
🤖 Hey ! The security scan report for the current pull request is available here. |
14 similar comments
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
🤖 Hey ! The security scan report for the current pull request is available here. |
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I6e2bf93ddac464c88a82683dc6e6b0846a6a6964 Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
|
🤖 Hey ! The security scan report for the current pull request is available here. |
1 similar comment
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
2 New Issues
0 Fixed Issues
0 Accepted Issues4 participants
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Change-Id: I941eb6668cf8c98cbd8ea8e8510062216a6a6964## Issues liées
Issues numéro: #2204
Quel est le comportement actuel ?
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
Autres informations