Skip to content

refactor: migrate exploded deps management to central catalog#2346

Open
shikanime wants to merge 2 commits into
mainfrom
shikanime/push-kwoxqrvlkvpu
Open

refactor: migrate exploded deps management to central catalog#2346
shikanime wants to merge 2 commits into
mainfrom
shikanime/push-kwoxqrvlkvpu

Conversation

@shikanime

@shikanime shikanime commented Jul 21, 2026

Copy link
Copy Markdown
Member

Change-Id: If3b2984ef4a55f36dbb49142cf047e2d6a6a6964

Issues liées

Issues numéro: #2248 #2341

Quel est le comportement actuel ?

Quel est le nouveau comportement ?

Cette PR introduit-elle un breaking change ?

Autres informations

@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch 20 times, most recently from b80b9e3 to 871d477 Compare July 21, 2026 12:57
@shikanime

shikanime commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

CI build failure root cause: stale pnpm-lock.yaml after the catalog migration.

Fails in apps/client/Dockerfile at:

RUN pnpm --filter @cpn-console/logger run build

with:

[ERR_PNPM_CATALOG_ENTRY_NOT_FOUND_FOR_SPEC] No catalog entry 'json-schema' was found for catalog 'runtime'.\n```\n\nFix:\n```bash\nrm pnpm-lock.yaml\npnpm install --ignore-scripts\ngit add pnpm-lock.yaml\n```\n\nI validated locally that the filtered logger/shared/hooks/client builds pass after lockfile regeneration.

@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch 2 times, most recently from 490047d to fb4f8fb Compare July 21, 2026 14:36
@github-actions github-actions Bot added the built label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch from fb4f8fb to 76953ca Compare July 21, 2026 14:42
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime
shikanime marked this pull request as ready for review July 21, 2026 14:45
@shikanime
shikanime requested a review from a team July 21, 2026 14:46
@shikanime shikanime self-assigned this Jul 21, 2026
@shikanime shikanime added technical debt Résoud de la dette technique tech Technical issue labels Jul 21, 2026
@shikanime shikanime added this to the 9.23.0 milestone Jul 21, 2026
@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch from 76953ca to 1ea8e59 Compare July 21, 2026 14:48
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime
fix: client dockerfile is missing hook package.json
ccba9f3 
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: If3b2984ef4a55f36dbb49142cf047e2d6a6a6964
@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch from 1ea8e59 to b865d3c Compare July 21, 2026 14:50
@shikanime
shikanime enabled auto-merge July 21, 2026 14:50
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch from b865d3c to ddb3ff3 Compare July 21, 2026 15:09
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch 2 times, most recently from 10915f1 to 364463f Compare July 21, 2026 15:20
@shikanime
refactor: migrate exploded deps management to central catalog
8e00dfc 
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: If3b2984ef4a55f36dbb49142cf047e2d6a6a6964
@shikanime
shikanime force-pushed the shikanime/push-kwoxqrvlkvpu branch from 364463f to 8e00dfc Compare July 21, 2026 15:23
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

@cloud-pi-native-sonarqube

cloud-pi-native-sonarqube Bot commented Jul 21, 2026

Copy link
Copy Markdown

Passed Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube

StephaneTrebel
StephaneTrebel reviewed Jul 24, 2026
View reviewed changes
Comment thread apps/client/package.json
"vitest": "catalog:test",
"vue-eslint-parser": "catalog:dev",
"vue-tsc": "catalog:build",
"workbox-window": "catalog:build"

@StephaneTrebel StephaneTrebel Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought(pas à traiter): Je me demande si un tri par catalog plutôt que par ordre alphabétique aurait plus de sens, à la lecture 🤔
Regrouper les build entre eux, les dev entre eux, etc.

Bon en vrai c'est juste le signe que la manière de gérer les dépendances en Node.js est éclaté au sol…

Comment thread apps/server-nestjs/package.json
"@nestjs/swagger": "catalog:runtime",
"@nestjs/terminus": "catalog:runtime",
"@opentelemetry/api": "catalog:otel",
"@opentelemetry/auto-instrumentations-node": "catalog:otel",

@StephaneTrebel StephaneTrebel Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Y a une raison de distinguer otel de runtime ?

Comment thread packages/tsconfig/package.json
"tag": "latest"
}
}
} No newline at end of file

@StephaneTrebel StephaneTrebel Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: problème de terminaison de fichier ?

Comment thread pnpm-workspace.yaml
# pnpm will install it. This applies to all dependencies, including transitive ones.
minimumReleaseAge: 1440 # 1 day

catalogMode: strict

@StephaneTrebel StephaneTrebel Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Oui 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephaneTrebel StephaneTrebel StephaneTrebel left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@shikanime shikanime

Labels

built tech Technical issue technical debt Résoud de la dette technique

Projects

None yet

Milestone

9.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shikanime @StephaneTrebel