update docs catalog#31675
Conversation
Review
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. ❌ This review could not complete this run; results may be incomplete. It will retry on the next push. Style Guide Review✅ No style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
CI run failed: build logs |
There was a problem hiding this comment.
Review summary
This PR updates the AI model catalog data in src/content/catalog-models/ with regenerated examples, code snippets, and metadata. It also adds 4 new model files.
What changed
- 4 new models:
alibaba/hh1.1-i2v,alibaba/hh1.1-r2v,alibaba/hh1.1-t2v,google/gemini-3.5-flash - ~115 existing models updated with refreshed examples,
raw_responsedata, code snippets, and schema metadata - Several models switched from
gatewayMetadata.keySource: "BYOK"to"Unified"
Issues found
❌ Build-breaking: openai-gpt-5.1-chat.json has "schema": null
pnpm run check fails with:
catalog-models → openai-gpt-51-chat data does not match collection schema.
schema: Expected type "object", received "object"
The Zod schema for catalog-models allows schema to be the object shape or undefined (omitted), but not null:
schema: z.object({ ... }).optional()In src/content/catalog-models/openai-gpt-5.1-chat.json, the schema field was removed from the diff but left as "schema": null at the end of the file. This must be fixed before the PR can merge.
Suggested fix: Either restore the JSON Schema object or remove the "schema": null key entirely.
Minor notes
- PR title/description: The title "update docs catalog" is vague, and the description body is the empty template. Consider updating the title to something like
[AI] Update Workers AI catalog modelsand adding a brief description of what changed and why. - Schema version:
openai-gpt-5.1-chat.jsonchangedschema_versionfrom"1.0.0"tonull. This is schema-valid (z.string().nullable()) but confirm this is intentional. - No redirects needed: Since no files were renamed or moved, redirects are not required.
- Lint/format: Pass cleanly.
Labels applied
content:edit, content:new, triage
|
I've completed the review of PR #31675. Here's what I did: Review posted
Summary of findingsWhat the PR changes:
Build-blocking issue flagged:
Minor issues noted:
Labels applied
|
Summary
Screenshots (optional)
Documentation checklist