refactor(link): collapse variants into a single underlined style - #702
Draft
FBalint wants to merge 1 commit into
Draft
refactor(link): collapse variants into a single underlined style#702FBalint wants to merge 1 commit into
FBalint wants to merge 1 commit into
Conversation
Remove the 'inline', 'current', and 'plain' Link variants in favor of a single 'default' variant that inherits color from the surrounding text and is always underlined. This drops the brand-blue link treatment Kumo used to ship. - link.tsx: single 'default' variant using text-current + underline - link.test.tsx: cover the single-variant shape; assert no text-kumo-link - LinkDemo/link.mdx/HomeGrid: drop per-variant showcases and prop usage - kumo-figma/link.ts: bind to text-default; handle 1-variant edge case (combineAsVariants requires 2+ components) - Changeset: major bump with migration guide
commit: |
Contributor
Docs PreviewCommit: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.























































































Link: drop the blue variants, keep the underlined one
Link used to ship three variants (inline, current, plain). WCAG requires an underline, we cannot depend on color. Underline only complies. Consolidating on a single underlined style that inherits color from the surrounding text kills the "which variant do I use" question and removes a text-kumo-link foot-gun for consumers with clashing app themes.
What changed