fix(overlays): normalize shadows and outlines on tip-style overlays - #705
Draft
FBalint wants to merge 1 commit into
Draft
fix(overlays): normalize shadows and outlines on tip-style overlays#705FBalint wants to merge 1 commit into
FBalint wants to merge 1 commit into
Conversation
- Drop shadow-kumo-tip-shadow color override; use default Tailwind shadow - Tune shadow sizes: shadow-md for Popover, Tooltip, ClipboardText tooltip, Chart tooltip; keep shadow-lg on ClipboardText toast - Switch outline-kumo-fill to outline-kumo-line to match other overlays - Rename kumo-tip-shadow/kumo-tip-stroke to kumo-arrow-edge/kumo-arrow-stroke; both now resolve to kumo-line so arrow border aligns with popup outline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popover, Tooltip, ClipboardText, and the Chart tooltip were using an opaque gray for both their drop shadow and their outline, which reads as a flat gray halo instead of an actual shadow.
Fix is to use true-black with alpha for both layers (Tailwind's default shadow + kumo-line outline) so where they overlap they deepen into a natural edge and fade continuously into the shadow beyond — same trick every other overlay in the library already uses.