chore(test): extend regexp to verify results from UserFriendlyDate function - #3842
Open
hainenber wants to merge 1 commit into
Open
Conversation
…nction Signed-off-by: hainenber <dotronghai96@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
On local machine, unit test for
UserFriendlyDatemachine could have different locale and in turns, failing the expected regexp with additional "+" or "-" in the timezone offset.This PR is to rectify such issue.
Before
After
Why Is This PR Valuable?
No changes to existing functionalities but to improve local developer experience.
Applicable Issues
N/A
How Urgent Is The Change?
No urgent
Other Relevant Parties
Only developers from different locales/timezones