refactor: replace external sirupsen/logrus with built-in log/slog for logging - #3844
Open
hainenber wants to merge 1 commit into
Open
refactor: replace external sirupsen/logrus with built-in log/slog for logging#3844hainenber wants to merge 1 commit into
sirupsen/logrus with built-in log/slog for logging#3844hainenber wants to merge 1 commit into
Conversation
… for logging Signed-off-by: hainenber <dotronghai96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please create separate PR for every branch (main and v8) as needed.
Description of the Change
Refactors whole codebase to use built-in
log/slogfor logging, making one less external dependency.Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Reduce possible attack surface and reduce external dep count for robust distribution process
Applicable Issues
List any applicable GitHub Issues here
N/A
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Not urgent
Other Relevant Parties
Who else is affected by the change?
Potentially teams/softwares relying on ever-existing log output by
cfbinary.