chore: Adds package json exports for test-utils dom wrappers#4750
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4750 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 951 951
Lines 30744 30744
Branches 11281 11280 -1
=======================================
Hits 30007 30007
- Misses 690 730 +40
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan-kot
enabled auto-merge
July 21, 2026 13:51
jperals
reviewed
Jul 22, 2026
| result[`./${component}`] = `./${component}/index.js`; | ||
| } | ||
|
|
||
| // Per-component test-utils DOM wrappers (e.g. `.../test-utils/dom/button`). |
Member
There was a problem hiding this comment.
Can't the per-component test utils already be imported from the root? Like
import { Component } from "@cloudscape-design/components/test-utils/dom";
Member
Author
There was a problem hiding this comment.
Ah, good point - I did not realise that we export them from the index file! I will cancel the PR and update my docs :)
Member
Author
There was a problem hiding this comment.
Wait, no.
The wrappers are indeed exported - but the whole idea is to avoid importing from /dom/index - doing so will augment the ElementWrapper.
I reopened the PR :)
jperals
approved these changes
Jul 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make individual test-utils dom wrappers exported via package.json exports. These are necessary for extending test utils when building component libraries on top of Cloudscape.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.