feat: add automatic skeleton rows to Table#4772
Draft
gethinwebster wants to merge 8 commits into
Draft
Conversation
gethinwebster
force-pushed
the
dev-v3-gethinw-table-auto-skeleton-rows
branch
from
July 23, 2026 07:22
5ba3e9e to
6978122
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4772 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 952 953 +1
Lines 30816 30897 +81
Branches 11318 11338 +20
=======================================
+ Hits 30081 30161 +80
- Misses 688 689 +1
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gethinwebster
temporarily deployed
to
allure-report
July 23, 2026 09:37 — with
GitHub Actions
Inactive
gethinwebster
force-pushed
the
dev-v3-gethinw-table-auto-skeleton-rows
branch
from
July 23, 2026 13:47
d5d08e1 to
95c275f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic skeleton-row sizing to Table via
skeleton={{ totalRows: 'auto' }}: during loading the table fills its available viewport with placeholder rows, and a post-render correction removes rows if the rendered page would overflow (never below one row).Changes
use-auto-skeleton-rows.ts, wired throughTableinternals and interfaces.wrapLineson/off with long headers, and mixed data + skeleton rows (data rows always precede skeleton rows).#/light/app-layout/auto-skeleton-table,...-nowrap) with an external#hheader and#ffooter, matching a real console layout.Testing
npm run build,npm run lint, and the table unit suites (17/17) pass.