Skip to content

feat: add automatic skeleton rows to Table#4772

Draft
gethinwebster wants to merge 8 commits into
mainfrom
dev-v3-gethinw-table-auto-skeleton-rows
Draft

feat: add automatic skeleton rows to Table#4772
gethinwebster wants to merge 8 commits into
mainfrom
dev-v3-gethinw-table-auto-skeleton-rows

Conversation

@gethinwebster

@gethinwebster gethinwebster commented Jul 23, 2026

Copy link
Copy Markdown
Member

Adds automatic skeleton-row sizing to Table via skeleton={{ totalRows: 'auto' }}: during loading the table fills its available viewport with placeholder rows, and a post-render correction removes rows if the rendered page would overflow (never below one row).

Changes

  • Automatic skeleton rows in use-auto-skeleton-rows.ts, wired through Table internals and interfaces.
  • Unit + browser integration coverage: sticky header, footer, wrapLines on/off with long headers, and mixed data + skeleton rows (data rows always precede skeleton rows).
  • AppLayout console-shell dev pages (#/light/app-layout/auto-skeleton-table, ...-nowrap) with an external #h header and #f footer, matching a real console layout.

Testing

  • npm run build, npm run lint, and the table unit suites (17/17) pass.
  • Browser integration tests run in CI.
  • Row-count oscillation risk was investigated with a real headless-Chrome probe (forced overflow, container churn, seed-height mismatch) — no oscillation and no ResizeObserver-loop warnings.

@gethinwebster gethinwebster changed the title Table: fix auto skeleton row overflow + layout coverage feat: add automatic skeleton rows to Table Jul 23, 2026
@gethinwebster
gethinwebster force-pushed the dev-v3-gethinw-table-auto-skeleton-rows branch from 5ba3e9e to 6978122 Compare July 23, 2026 07:22
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.80952% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.61%. Comparing base (f97729a) to head (95c275f).

Files with missing lines Patch % Lines
src/table/use-auto-skeleton-rows.ts 98.41% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4772   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         952      953    +1     
  Lines       30816    30897   +81     
  Branches    11318    11338   +20     
=======================================
+ Hits        30081    30161   +80     
- Misses        688      689    +1     
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant