feat: Table bulk inline edit (v0, AWSUI-56121) [WIP]#4818
Draft
ernst-dev wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4818 +/- ##
==========================================
- Coverage 97.61% 97.60% -0.01%
==========================================
Files 952 953 +1
Lines 30816 30889 +73
Branches 11318 11326 +8
==========================================
+ Hits 30081 30150 +69
- Misses 688 732 +44
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The bulk-editable dev page rendered {lastCommit && <StatusIndicator/>} where
lastCommit is a string. When empty, this evaluates to '' (an empty-string text
child) rather than false, which SpaceBetween flattens into a keyless child and
renders inside a mapped list. React then logs a SEVERE 'unique key' console
warning, which the accessibility test harness treats as a failure.
Use a ternary so the falsy branch is null and no keyless child is produced.
ernst-dev
had a problem deploying
to
allure-report
July 23, 2026 16:49 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[WIP / v0 — do not merge] First-cut (v0) of an opt-in bulk inline editing mode for
Table, tracked by SIM AWSUI-56121. Bulk inline edit lets users edit multiple editable cells at once (a "bulk edit mode") and commit them together via a single callback, rather than editing one cell at a time.This is an epic-sized, multi-week feature; this PR is a coherent, buildable starting point that layers on top of the existing single-cell inline-edit (
editConfig) machinery. It is additive and opt-in — with nobulkEditprop the Table behaves exactly as before (verified: the only behavioral tie-in is gated onbulkEditing.isActive, which is alwaysfalsewhen disabled).Related links, issue #: AWSUI-56121 (see mismatch note above)
What's included (v0 / done)
useBulkEditinghook (src/table/use-bulk-editing.ts) — the core, UI-agnostic state machine:startBulkEdit/discardBulkEdit)(rowId, columnId)withsetCellValue/clearCellValue/getCellValuecollectChanges()resolves pending edits back to{ item, column, newValue }submitBulkEdit()— commit-all with a submitting state, callsbulkEdit.onSubmit({ changes })trackBy-aware row identity with row-index fallbacksrc/table/interfaces.tsx), fully JSDoc'd:bulkEdit?: TableProps.BulkEditConfig<T>propTableProps.BulkEditConfig,TableProps.BulkEditSubmitDetail,TableProps.BulkEditChangeinternal.tsx— instantiates the controller behind the opt-in prop; no-op whenbulkEditis absent.pages/table/bulk-editable.page.tsx) demonstrating the intended UX (Edit all → cells become inputs → Save all / Discard all), reusing existing input pieces.src/table/__tests__/use-bulk-editing.test.tsx) — 6 tests covering enable/disable, enter/exit, dirty tracking, change collection, commit-all, and trackBy fallback.bulkEditprop.Remaining work (follow-ups, not in this PR)
editConfig.editingCelleditors automatically in bulk mode (today the dev page renders editors itself).ariaLabelsintegration.editConfig.validation, and surfacing errors before/after commit-all.disabledReasonhandling and per-cell "dirty"/"error" visual states.onSubmit(keep failed cells dirty).How has this been tested?
eslint(Node v24) on all changed/new files — clean.npm run quick-build(TypeScript) — pass.npm run build(full build incl. definitions generation) — pass.jest -c jest.unit.config.js:src/table/__tests__/use-bulk-editing.test.tsx— 6/6 passsrc/table/__tests__/table-editable.test.tsx(regression) — 5/5 passsrc/__tests__/snapshot-tests/documenter.test.ts— 97/97 pass (snapshot updated forbulkEdit)Reviewers can open the
Table/bulk-editabledev page to try the flow.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.