feat(reservations): follow VM live migration in CR reservation reconciler#1048
Draft
juliusclausnitzer wants to merge 3 commits into
Draft
feat(reservations): follow VM live migration in CR reservation reconciler#1048juliusclausnitzer wants to merge 3 commits into
juliusclausnitzer wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
juliusclausnitzer
changed the title
Contributor
Test Coverage ReportTest Coverage 📊: 70.4% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #373. When the reservation reconciler detects that a
confirmed VM has disappeared from its expected host, it now searches all
hypervisor CRDs to determine whether the VM live-migrated rather than
treating it as terminated.
Spec.TargetHostis updated to the newhost. The existing TargetHost→Status.Host sync path (Branch B in
Reconcile) advancesStatus.Hoston the next cycle, keepingcapacity accounting consistent during the transition.
TargetHostis left unchanged; theVM's actual location is recorded in
Status.Allocations; the newVMMisplacedcondition is set with reasonMigratedToFullHost.unchanged.
Only the migrating VM's host is considered per-reconcile. Other
allocated VMs in the same reservation are not moved.
The HV list is fetched lazily — only when a confirmed VM is actually
missing from its expected host — so the common path (no migration)
pays no extra API cost.