You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat(sdk-trace-base): pretty-print SpanImpl, Tracer, and BasicTracerProvider via util.inspect so they render through diag and console.log#6690@mcollina
feat(sdk-trace-base): pretty-print SpanImpl, Tracer, and BasicTracerProvider via util.inspect so they render through diag and console.log#6690@mcollina
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the newrelic dependency to version 14.3.3. However, there is a significant gap in the implementation: while the PR title and acceptance criteria specify an update for @opentelemetry/core (v2.2.0 to v2.8.0), this package is not included in the package.json changes.
Furthermore, although Codacy quality checks are passing, the update for the New Relic agent constitutes a major version jump (v13 to v14). The lack of accompanying test scenarios to verify telemetry reporting or agent initialization poses a regression risk that should be addressed before merging.
About this PR
The PR title and acceptance criteria state an update to '@opentelemetry/core' from version 2.2.0 to 2.8.0, but this dependency change is missing from the package.json file. Please verify if this was intended to be a direct dependency update or if it was mistakenly omitted.
The update for 'newrelic' involves a major version jump from v13 to v14. No tests have been provided to verify that the application still successfully initializes or that telemetry data is reported correctly under the new version.
Test suggestions
Verify application successfully initializes and reports telemetry data using New Relic agent v14
Ensure no breaking changes from the @opentelemetry/core v2.7.1 TraceState logic affect current implementation
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify application successfully initializes and reports telemetry data using New Relic agent v14
2. Ensure no breaking changes from the @opentelemetry/core v2.7.1 TraceState logic affect current implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency filejavascriptPull requests that update javascript code
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependabot
Bot
added
dependencies
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Bumps @opentelemetry/core to 2.8.0 and updates ancestor dependency newrelic. These dependencies need to be updated together.
Updates
@opentelemetry/corefrom 2.2.0 to 2.8.0Release notes
Sourced from @opentelemetry/core's releases.
... (truncated)
Changelog
Sourced from @opentelemetry/core's changelog.
... (truncated)
Commits
13a035bchore: prepare next release (#6756)4b13587Merge commit from fork71d195cchore(renovate): set minimumReleaseAge to 3 days (#6792)555fca6Update renovate.json to use matchManagers (#6141)b711a81docs(otlp-exporter-base): add typedoc entry points so public API is indexed a...da70402fix(ci): supply-chain sec: disable caching in release-related workflow (#6790)002267bchore: complete the move to the smaller SPDX license header (#6791)056ef9cfeat(sdk-metrics): implement metric reader metrics (#6449)3bd69cefix(configuration): improve environment variable substitution to handle all t...bfbda7cdocs(exporter-trace-otlp-grpc): import CompressionAlgorithm from otlp-exporte...Updates
newrelicfrom 13.6.5 to 14.3.3Release notes
Sourced from newrelic's releases.
... (truncated)
Changelog
Sourced from newrelic's changelog.
... (truncated)
Commits
e3f055achore: release v14.3.3 (#4164)f31bbe4fix: Avoid unconditional@opentelemetry/corerequire on agent startup (#4163)3b440f3feat: Collect on-CPU time alongside wall time inCpuProfiler(#4146)b014f82feat: Add internal OTEL API to agent (#4147)8ba64fbdocs: Updated compatibility report (#4160)8a79ec3chore: release v14.3.2 (#4159)ca4a7b0test: Fixed srv-connect DNS patching across mongodb driver versions (#4158)6058cf7docs: Updated compatibility report (#4156)7fd4443fix: Resolved mongodb host details at operation time to support `mongodb+srv:...136f65adocs: Updated compatibility report (#4153)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.