Bump node-forge from 1.3.1 to 1.4.0 - #5004
Conversation
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.1 to 1.4.0. - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.3.1...v1.4.0) --- updated-dependencies: - dependency-name: node-forge dependency-version: 1.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to update node-forge to version 1.4.0 to address high-severity security vulnerabilities, including Denial of Service and signature forgery (CVE-2026-33891, CVE-2026-33894, CVE-2026-33895, and CVE-2026-33896). While the PR title and intent are clear, the actual update to the package.json manifest is currently missing from the diff. This gap means the intended security patches are not yet applied to the project. Furthermore, the PR lacks verification tests to ensure that existing cryptographic operations remain compatible with the new library version.
About this PR
- The required update to
package.jsonis missing. To fulfill the PR objective and mitigate the identified CVEs, the project manifest must be updated to specifynode-forgeversion 1.4.0.
Test suggestions
- Verify that
package.jsonis updated to specifynode-forgeversion 1.4.0. - Ensure existing cryptographic operations (signing, verification, certificate handling) remain functional with the new version.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that `package.json` is updated to specify `node-forge` version 1.4.0.
2. Ensure existing cryptographic operations (signing, verification, certificate handling) remain functional with the new version.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps node-forge from 1.3.1 to 1.4.0.
Changelog
Sourced from node-forge's changelog.
... (truncated)
Commits
fa385f9Release 1.4.0.07d4e16Update changelog.cb90fd9Update changelog.963e7c5Add unit test for "pseudonym"f0b6f5bAdd pseudonym OID3df48a3Fix missing CVE ID.2e49283Add x509basicConstraintscheck.bdecf11Add canonical signature scaler check for S < L.af094e6Add RSA padding and DigestInfo length checks.796eeb1Improve jsbn fix.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.